[Mono-devel-list] [Fwd: [Mono-patches] r38601 - trunk/mcs/class/System.XML/Test/System.Xml]

[Atsushi Eno]

Hi Nickd,

Am reverting the patch #38601.

> @@ -148,6 +148,14 @@
>  
>  		private delegate void TestMethod (XmlReader reader);
>  
> +		private void RunTest2 (string xml, TestMethod method)
> +		{
> +			document.XmlResolver = null;
> +			document.LoadXml (xml);
> +			xnr = new XmlNodeReader (document);
> +			method (xnr);
> +		}
> +

You should not skip all the XmlNodeReader tests.


> @@ -249,6 +253,23 @@
>  			Assert (reader.ReadAttributeValue ());
>  			// MS.NET XmlTextReader fails. Its Prefix returns null instead of "".
>  			this.AssertNodeValues (reader, XmlNodeType.Text,
> +				2, false, "", null, "", null, "", true, 1, true);
> +			Assert (reader.MoveToElement ());
> +			this.AssertNodeValues (reader, XmlNodeType.Element,
> +				0, true, "root", "", "root", "", "", false, 1, true);
> +		}

This is a bug in MS XmlTextReader and XmlValidatingReader that are
fixed in .NET 2.0. I will note it here.

Thanks for taking care of run-test-ondotnet stuff btw ;-)

Atsushi Eno