[Mono-dev] RE: [Mono-patches] r48374 - in trunk/mcs/class/System.Drawing: .System.Drawing Test/System.Drawing

Andrew Skiba andrews at mainsoft.com
Tue Aug 16 07:58:25 EDT 2005


Hi Gert.

You wrote:
> I'm still working on additional fixes and tests, I should get 
> things stable today (meaning tests should pass on both mono 
> and MS.NET).
> 
> Gert

Can you make things stable before committing, please? We are actively
working on System.Drawing these days, and it is very disturbing when
tests fail on mono and dotnet (before we speak about java).

Also it takes time to review commits if they are lengthy, have
reformatting changes like 

-
-using NUnit.Framework;
 using System;
-using System.Drawing;
 using System.Collections;
 using System.ComponentModel;
+using System.Drawing;
 using System.Globalization;
+using System.Threading;

+using NUnit.Framework;
+

and svn:eol-style changes for tens of files. Can you at least during our
active development in the same namespace try to minimize diffs? It's
fine to remove unused TearDown functions and Assertion inheritance
sometime, but why to do it now, when we work on the very same files, so
it can produce more conflicts?

Thank you.
Andrew.



More information about the Mono-devel-list mailing list