[Mono-devel-list] Patch for RfcModifyDNRequest

[Boris Kirzner]

Hello all
Attached is the better patch for the same problem (see my previous mail 
below).
- According to RFC 2251 newSuperior should be sent as context-specific 0 
type rather than octet string.

- Create an instance of RfcModifyDNRequest for LdapModifyDNRequest using 
new type for newSuprerior parameter - RfcLdapSuperDN (encoded as 
context-specific 0 type).

If no one objects, I'm going to commit.

Thanks,
Boris



Boris Kirzner wrote:

> Hello all
> Attached is a patch for RfcModifyDNRequest class :
> - According to RFC 2251 newSuperior should be sent as context-specific 
> 0 type rather than octet string.
>
> If no one objects, I'm going to commit.
> Boris
>
>------------------------------------------------------------------------
>
>Index: RfcModifyDNRequest.cs
>===================================================================
>--- RfcModifyDNRequest.cs	(revision 42306)
>+++ RfcModifyDNRequest.cs	(working copy)
>@@ -52,6 +52,16 @@
> 		//*************************************************************************
> 		// Constructors for ModifyDNRequest
> 		//*************************************************************************
>+
>+		// according to RFC 2251 :
>+		// ModifyDNRequest ::= [APPLICATION 12] SEQUENCE {
>+		//   entry           LDAPDN,
>+		//   newrdn          RelativeLDAPDN,
>+		//   deleteoldrdn    BOOLEAN,
>+		//   newSuperior     [0] LDAPDN OPTIONAL
>+		// }
>+		// i.e. newSuperior is a context-specific 0.
>+		static readonly Asn1Identifier superiorId = new Asn1Identifier(Asn1Identifier.CONTEXT,false,0x0);
> 		
> 		/// <summary> </summary>
> 		public RfcModifyDNRequest(RfcLdapDN entry, RfcRelativeLdapDN newrdn, Asn1Boolean deleteoldrdn):this(entry, newrdn, deleteoldrdn, null)
>@@ -64,8 +74,10 @@
> 			add(entry);
> 			add(newrdn);
> 			add(deleteoldrdn);
>-			if (newSuperior != null)
>+			if (newSuperior != null) {
>+				newSuperior.setIdentifier(superiorId);
> 				add(newSuperior);
>+			}
> 		}
> 		
> 		/// <summary> Constructs a new Delete Request copying from the ArrayList of
>  
>

-- 
Boris Kirzner
Mainsoft Corporation
http://www.mainsoft.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050404/148dff5f/attachment.html 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: RfcLdapSuperDN.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050404/148dff5f/attachment.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: RfcModifyDNRequest.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050404/148dff5f/attachment-0001.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: LdapModifyDNRequest.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050404/148dff5f/attachment-0002.pl