[Mono-devel-list] String.Replace patch to Managed code.

[grompf]

In my effort to address bug #59274, I tracked the problem down to 
icu/glib in locales.c not replacing \0.

Attached is a patch for String.cs to replace the internal methods with 
managed code.

There is probably a more efficient way of Replace(String, String), but 
both of these methods have been tested and working for bug #59274 as 
well as other Replace testings.  However, I'm a little unsure how to 
test the culture dependancy of Replace(String, String).  Considering 
the IndexOf call should determine the culture as well, it _should_ be 
ok as far I understand the culture dependancy stuff.

If this looks good, let me know and I'll move on to some other methods 
(like IndexOf).

-kangaroo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/enriched
Size: 698 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040531/7e44def3/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: StringReplaceToManaged.patch
Type: application/octet-stream
Size: 1685 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040531/7e44def3/attachment.obj 
-------------- next part --------------

On 31-May-04, at 2:44 PM, Attila Balogh wrote:

>
>
>
> !DSPAM:40bb7d3a211279950511274!
>
> From: Attila Balogh <d0lphin at mail.edu-net.hu>
> Date: May 31, 2004 2:43:37 PM EDT
> To: Stefan Domnanovits <domo at domnanovits.at>
> Subject: Re: [Mono-list] 0.9x can't compile on mac os x
>
>
> Stefan Domnanovits wrote:
>
>> I had the same problem. After doing a
>>
>>   sudo ranlib /sw/lib/libintl.a
>>
>> the error dissapeared.
>>
>>
>> regards,
>>
>> Stefan
>>
>> Attila Balogh wrote:
>>
>>> hello all,
>>>
>>> i'm still getting the same error message when trying to compile mono 
>>> (i tried 0.92-3-4 and cvs version when i could grab them - 0.91 
>>> builds without errors of course), the error occurs at mini:
>>>
>>> gcc -g -O2 -fno-strict-aliasing -g -Wall -Wunused 
>>> -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes 
>>> -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-cast-qual 
>>> -Wcast-align -Wwrite-strings -pthread -o mono main.o  
>>> ./.libs/libmono.a -L/sw/lib -lgthread-2.0 -lgmodule-2.0 -lglib-2.0 
>>> /sw/lib/libintl.a -liconv -licui18n.28 -licuuc.28 -licudata.28 
>>> -lpthread -lm
>>> gcc: unrecognized option `-pthread'
>>> ld: table of contents for archive: /sw/lib/libintl.a is out of date; 
>>> rerun ranlib(1) (can't load from it)
>>> make[4]: *** [mono] Error 1
>>> make[3]: *** [all] Error 2
>>> make[2]: *** [all-recursive] Error 1
>>> make[1]: *** [all-recursive] Error 1
>>> make: *** [all] Error 2
>>>
>>> any ideas, is this a bug or i'm messing something up?
>>> regards;
>>>
>>> Attila
>>> _______________________________________________
>>> Mono-list maillist  -  Mono-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-list
>>>
>>
> Thanks a lot Stefan, make ran without problems, now trying make 
> bootstrap.
> Attila
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/enriched
Size: 1945 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040531/7e44def3/attachment-0001.bin