[Mono-devel-list] Html32TextWriter
Gonzalo Paniagua Javier
gonzalo at ximian.com
Wed May 12 03:18:32 EDT 2004
El lun, 10-05-2004 a las 22:47, Gonzalo Paniagua Javier escribió:
> El lun, 10-05-2004 a las 17:08, meddochat (Matthijs ter Woord) escribió:
> > Could somebody please commit it to cvs?
>
> I have some more comments:
> * Using MS style of documenting source files is discouraged. We
> have monodoc for documenting files. For the rationale of this,
> search in mono lists.
I removed this comments.
> * GetTagName (HtmlTextWriterTag tagKey) has a pretty big switch
> that can be changed to just:
> if (tagKey == HtmlTextWriterTag.Unknown ||
> !Enum.IsDefined (typeof (HtmlTextWriterTag), tagkey))
> return "";
> return tagkey.ToString ().Tolower
> (CultureInfo.InvariantCulture);
Added these lines and let the big switch commented out for later usage.
> * If you have a standalone test for this class, please, send it
> too.
> * You say it's a partial implementation. What's missing?
I've seen it. It's just a stub ;-).
Thanks. It's in CVS now.
-Gonzalo
More information about the Mono-devel-list
mailing list