[Mono-devel-list] Html32TextWriter

Gonzalo Paniagua Javier gonzalo at ximian.com
Mon May 10 16:47:37 EDT 2004


El lun, 10-05-2004 a las 17:08, meddochat (Matthijs ter Woord) escribió:
> Could somebody please commit it to cvs?

I have some more comments:
      * Using MS style of documenting source files is discouraged. We
        have monodoc for documenting files. For the rationale of this,
        search in mono lists.
      * GetTagName (HtmlTextWriterTag tagKey) has a pretty big switch
        that can be changed to just:
                if (tagKey == HtmlTextWriterTag.Unknown ||
                  !Enum.IsDefined (typeof (HtmlTextWriterTag), tagkey))
                	return "";
                return tagkey.ToString ().Tolower
                (CultureInfo.InvariantCulture);
      * If you have a standalone test for this class, please, send it
        too.
      * You say it's a partial implementation. What's missing?

Thanks.

-Gonzalo

                




More information about the Mono-devel-list mailing list