[Mono-devel-list] Patch for bug #54797

Gonzalo Paniagua Javier gonzalo at ximian.com
Wed Mar 17 15:54:02 EST 2004


El mié, 17-03-2004 a las 15:29, Francois Beauchemin escribió:
> >Can you provide a patch against current CVS?
> >
> >  
> >
> Sure . See attached file

Patch applied, thanks.

However, you seem to have converted all your files to unix endings,
which made the patch unusable. I had to convert to DOS format for a few
of files which already have that.

> 
> >You should also read mcs/class/README with regard to the coding style
> >used in mono.
> >
> >  
> >
> I've looked the coding style, beside some line too long (corrected ) i 
> can't see where i'm wrong. Could you point me some piece of code where 
> i'm wrong ?

For example:

-> OpCode anch_op = (OpCode)(program[pc + 3] & 0x00ff);
it should be like: (OpCode) (program [pc + 3] & 0x00ff)

-Gonzalo





More information about the Mono-devel-list mailing list