[Mono-devel-list] [PATCH] Large patch for Reflection.Emit

Paolo Molaro lupus at ximian.com
Wed Jun 9 11:04:24 EDT 2004

On 06/08/04 Gert Driesen wrote:
> * EnumBuilder.cs: implemented EnumBuilder as wrapper class for
> TypeBuilder, meaning rely on TypeBuilder implementation as
> an enum is just a special type.
> * MethodBuilder.cs: move check to see if type has already up
> to match MS.NET behaviour, fix GetHashCode (removed TODO)

These look fine to commit. Please also commit the tests.

> * TypeBuilder.cs: removed code duplication as we do not need
> to return methods/events/properties when type has not been
> created, fixed Get* methods to return actual events/fields/...
> when type has been completed, implemented IsCOMObjectImpl,
> removed unnecessary FIXME's

Most of the changes in TypeBuilder.cs look too intrusive this late
in the release process and IIRC some of the code you remove was added
because it was needed and we didn't want to match the MS misfeatures in
some cases. I suggest you apply just the FIXME-removing hunks and the
simple property fixes and save the rest of the patch in a bugzilla bug
so it doesn't get lost.


lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better

More information about the Mono-devel-list mailing list