[Mono-devel-list] [PATCH] Large patch for Reflection.Emit

Gert Driesen gert.driesen at pandora.be
Tue Jun 8 16:29:34 EDT 2004


I've attached quite a large patch (with a large set of unit tests) for Reflection.Emit: 

* EnumBuilder.cs: implemented EnumBuilder as wrapper class for
TypeBuilder, meaning rely on TypeBuilder implementation as
an enum is just a special type.

* MethodBuilder.cs: move check to see if type has already up
to match MS.NET behaviour, fix GetHashCode (removed TODO)

* TypeBuilder.cs: removed code duplication as we do not need
to return methods/events/properties when type has not been
created, fixed Get* methods to return actual events/fields/...
when type has been completed, implemented IsCOMObjectImpl,
removed unnecessary FIXME's

However, there are some (runtime ?) issues which causes some EnumBuilder tests to fail, so I've marked them with an Ignore attribute. Can someone have a look at these issues ?

Can someone please review this patch ?

Thanks !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040608/07d8dda0/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: emit.patch
Type: application/octet-stream
Size: 35465 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040608/07d8dda0/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: emit-test.patch
Type: application/octet-stream
Size: 59621 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040608/07d8dda0/attachment-0001.obj 

More information about the Mono-devel-list mailing list