[Mono-devel-list] Newline Constants Incorrect in Microsoft.VisualBasic

[Jason Bouzane]

Hello,

I noticed this a while ago (before the errors were posted on the status 
page), and this still hasn't been fixed, so I thought I'd write a patch.

The VB carriage return and linefeed characters are reversed in all the 
constants in the Microsoft.VisualBasic namespace in the Constants.cs and 
ControlChars.cs files. I've included a patch to fix this problem.

Furthermore, it looks like BinaryVBFile and InputVBFile both use "\r" to 
check for newline without looking for "\n", and when it encounters a 
"\r" at the end of a line, it doesn't check for a "\n" after it, so the 
"\n" will remain in the stream, and the code will probably be broken on 
Mac/Unix.

Any comments on this are welcome,
Jason Bouzane
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: newline.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040716/282a6b01/attachment.pl