[Mono-devel-list] [PATCH] changes in System.Data

Jackson Harper jackson at ximian.com
Sun Nov 9 12:41:07 EST 2003


Hello,

	Your patch looked good but when you commited it looks like you commited
alot of line ending changes. When this happens we loose all of our CVS
history. Please watch out for this in the future.

Jackson


On Sun, 2003-11-09 at 08:05, Eran Domb wrote:
> Oops,
> Here is the diff.
> 
> Eran Domb.
> 
> -----Original Message-----
> From: yoros at wanadoo.es [mailto:yoros at wanadoo.es] 
> Sent: Sunday, November 09, 2003 6:03 PM
> To: Eran Domb
> Cc: mono-devel-list at lists.ximian.com
> Subject: Re: [Mono-devel-list] [PATCH] changes in System.Data
> 
> On Sun, Nov 09, 2003 at 04:25:26PM +0200, Eran Domb wrote:
> > Hi
> > I made some changes in System.Data:
> > * DataColumn.cs (AllowDBNull) : Throw an exception.
> >  
> >             * DataRow.cs (this[]) : First check if row is deleted.
> >             (ItemArray) : First check if row is deleted.
> >             (SetColumnValue) : Initiate error message when null
> > violation happens. Check for array type when
> >             setting the value of the row.
> >             (EndEdit) : Check that the table's row is not in loading
> > before validating constrains.
> >             (CheckNullConstraints) : new method for validating null
> > constraint violations.
> >  
> >             * DataRowCollection.cs (ValidateDataRowInternal) : Adding
> > validation of null constraint violation.
> >             
> >             * DataSet.cs (CaseSensitive) : After changing the value -
> > check constrains.
> >             (EnforceConstraints) : When changing the value to true
> > assert all constraints.
> >             
> > *         UniqueConstraint.cs (AssertConstraint,CalcHashValue,
> > RowsComparer) : Adding support for case insensitive comparison.
> >  
> >  
> > If no one objects I will commit.
> >  
> 
> Please send the diffs.




More information about the Mono-devel-list mailing list