[Mono-devel-list] Re: [Mono-docs-list] Monodoc bug Redux

[Miguel de Icaza]

Hello,

> Ok this is patch is more adecuate: This patch doesn't brake the build of
> mono and mcs. It passes the tests. The problem is in the implementation
> of the elementStack it all is well when ckecking well-formedness of the
> xml documents but when validating the elementstacks (like p, a, class,
> etc) fall to 0 reguraly. The purpose of XmlTextReader (from MS): Because
> the XmlTextReader does not perform the extra checks required for data
> validation, it provides a fast well-formedness parser.
> So we don't care about validating in Reader, so the elementStacks from
> xsl (a, p , class ,etc) doesn't need to be checked in the error if.
> 
> Really need suggestions or confirmation thanks

I do not understand why this happening.  Why does this patch hard-code
knowledge about class, struct, delegate, enum and p?  This does not look
right.

If the XmlReader fails with genuine XML, we should have a test case, and
work from that to fix it.

I just noticed that Monodoc is in fact failing for most Xml documents,
with a crash like this:



Unhandled Exception: System.Xml.XmlException: document has terminated,
cannot open new element Line 7, position 3.
in <0x000c1> 00 System.Xml.XmlTextReader:ReadStartTag ()
in <0x000bb> 00 System.Xml.XmlTextReader:ReadTag ()
in <0x000ee> 00 System.Xml.XmlTextReader:ReadContent ()
in <0x0002b> 00 System.Xml.XmlTextReader:Read ()
in <0x00080> 00 System.Xml.XmlDocument:ReadNode (System.Xml.XmlReader)
in <0x00032> 00 System.Xml.XmlDocument:Load (System.Xml.XmlReader)
in <0x00170> 00 .EcmaProvider:Htmlize (System.Xml.XmlNode)
in <0x0026f> 00 .EcmaProvider:RenderClassSummary
(System.Xml.XmlDocument,string)