[Mono-bugs] [Bug 685571] New: AvoidLargeClassesRule
bugzilla_noreply at novell.com
bugzilla_noreply at novell.com
Wed Apr 6 14:18:13 EDT 2011
https://bugzilla.novell.com/show_bug.cgi?id=685571
https://bugzilla.novell.com/show_bug.cgi?id=685571#c0
Summary: AvoidLargeClassesRule
Classification: Mono
Product: Mono: Tools
Version: SVN
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P5 - None
Component: Gendarme
AssignedTo: mono-bugs at lists.ximian.com
ReportedBy: jordimash at gmail.com
QAContact: mono-bugs at lists.ximian.com
Found By: ---
Blocker: ---
User-Agent: Mozilla/5.0 (X11; U; Linux i686; ca; rv:1.9.2.16)
Gecko/20110323 Ubuntu/10.10 (maverick) Firefox/3.6.16
Hello,
Unfortunally this rules as is nowadays misses many complex classes, including
God classes.
The AvoidLargeClassesRule uses the number of fields to detect a large class.
This idea comes from Martin Fowler book refactoring, where he also mentions
that code size is a good metric (as common sense indicates).
We should definitely take into account the Code size IL instructions or LOCs.
This will bring consistency with AvoidLongMethodsRule that uses this metrics
too.
I can prepare a patch in this direction is needed.
Thanks,
Jordi,
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the mono-bugs
mailing list