[Mono-bugs] [Bug 354663] New: Review: IsUnsigned definition in expression.cs

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=354663


           Summary: Review: IsUnsigned definition in expression.cs
           Product: Mono: Compilers
           Version: unspecified
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: C#
        AssignedTo: mono-bugs at lists.ximian.com
        ReportedBy: miguel at novell.com
         QAContact: mono-bugs at lists.ximian.com
          Found By: ---


The definition for IsUnsigned in expression.cs (consumed by code that needs to
generate Binary expressions) seems incorrect, from the name:

                static bool IsUnsigned (Type t)
                {
                        if (t.IsPointer)
                                return IsUnsigned (t.GetElementType ());

                        return (t == TypeManager.uint32_type || t ==
TypeManager.uint64_type ||
                                t == TypeManager.short_type || t ==
TypeManager.byte_type);
                }

The "short_type" there should probably be "ushort_type"


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.