[Mono-bugs] [Bug 64675][Wis] Changed - [PATCH] Avoid long encodings for push operations

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by vargaz@freemail.hu.

http://bugzilla.ximian.com/show_bug.cgi?id=64675

--- shadow/64675	2004-08-30 15:26:28.000000000 -0400
+++ shadow/64675.tmp.25458	2004-08-31 08:40:18.000000000 -0400
@@ -1,14 +1,14 @@
 Bug#: 64675
 Product: Mono: Runtime
 Version: unspecified
-OS: 
+OS: unknown
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Wishlist
 Component: misc
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: bmaurer@users.sf.net               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -20,6 +20,14 @@
 enabling this, overall code size was reduced by over one percent.
 
 ------- Additional Comments From bmaurer@users.sf.net  2004-08-30 15:26 -------
 Created an attachment (id=9988)
 patch
 
+
+------- Additional Comments From vargaz@freemail.hu  2004-08-31 08:40 -------
+I would rename push_imm_long to push_imm_template to follow the naming
+convention used on other platforms, and define it as:
+
+#define x86_push_imm_template(inst) x86_push_imm ((inst), 0xf0f0f0)
+
+Other than this, this is ok to check in.