[Mono-bugs] [Bug 48337][Min] Changed - XmlTextReader allows dup attribute if defined in duplicate namespaces.

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 10 Sep 2003 13:03:25 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer@users.sf.net.


--- shadow/48337	2003-09-10 12:16:11.000000000 -0400
+++ shadow/48337.tmp.2705	2003-09-10 13:03:25.000000000 -0400
@@ -5,13 +5,13 @@
 OS Details: 
 Status: NEW   
 Severity: Unknown
 Priority: Minor
 Component: System.XML
-AssignedTo: mono-bugs@ximian.com                            
+AssignedTo: ginga@kit.hi-ho.ne.jp                            
 ReportedBy: bmaurer@users.sf.net               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
 Summary: XmlTextReader allows dup attribute if defined in duplicate namespaces.
@@ -90,6 +90,21 @@
   ValueTokenCollection valueTokens;
 It won't be so long before I got started to change it, so currently I 
 have no intention to fix this bug with existing code. It would be 
 better if we can discuss in depth.
+------- Additional Comments From bmaurer@users.sf.net  2003-09-10 13:03 -------
+Yeah, lets not fix this in existing code.
+For the name of the attribute, it would be better to just store the 
+String from the ns and localname. you will be getting the strings 
+from the NameTable, so you dont hurt memory allocation. Also, watch 
+out for allocating instances of that class. It would almost be better 
+to use a FlyWeight (like my HighWaterStack), so that we can only 
+allocate a few objects.
+Also, we really shouldnt have to allocate *any* such objects if we 
+are reading sequentally, rather than pulling the elements by name.
+I am assigning this bug to you.