[Mono-bugs] [Bug 48337][Min] Changed - XmlTextReader allows dup attribute if defined in duplicate namespaces.

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 10 Sep 2003 12:16:11 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by ginga@kit.hi-ho.ne.jp.


--- shadow/48337	2003-09-09 21:11:46.000000000 -0400
+++ shadow/48337.tmp.1780	2003-09-10 12:16:11.000000000 -0400
@@ -1,14 +1,14 @@
 Bug#: 48337
 Product: Mono/Class Libraries
 Version: unspecified
+OS: unknown
 OS Details: 
 Status: NEW   
+Severity: Unknown
 Priority: Minor
 Component: System.XML
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: bmaurer@users.sf.net               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -74,6 +74,22 @@
 Hashtable/ArrayList combo with an array of a new class AttrInfo. It should
 hold the parsed name and value. We can do a search through the list for
 duplicate attributes (since the number of attributes on an element is
 usually few, the speed benefit from the Hashtable is outweighted by the
 cost of hashing). Since all the names will be taken from the NameTable, we
 can use Object.ReferenceEquals, and avoid the cost of a string compare.
+------- Additional Comments From ginga@kit.hi-ho.ne.jp  2003-09-10 12:16 -------
+Excellent. In fact I have a (near) future plan to replace existing 
+code with such token information structures with indices of current 
+tag buffer, such as:
+internal class AttributeTokenInfo
+  int nameStart;  int nameEnd;
+  int quotedStart;  int quotedEnd;
+  ValueTokenCollection valueTokens;
+It won't be so long before I got started to change it, so currently I 
+have no intention to fix this bug with existing code. It would be 
+better if we can discuss in depth.