[Gtk-sharp-list] RadioButton api

John Luke jluke@users.sourceforge.net
Fri, 09 Jan 2004 14:23:11 -0500

> Couple of comments.  Since you are hiding all of the RadioButton ctors,
> instead of using 6 lines in the metadata, you can get it with one line: 
> <attr path="/api/namespace/object[@cname='GtkRadioButton']/constructor"
> name="hidden">1</attr>

Indeed if I was hiding them all I would do this, but there is two ctors
I don't want to hide. (One in the previous patch).  Also, I realized one
of the contructors I was hiding could now be used instead of having it
in the .custom file because it would no longer conflict. 

> Second.  When removing a metadata line, please make sure that it's
> effects are removed from the api.xml file.  There are still a couple of
> null_ok attrs left on those constructors in the patch.  Unfortunately,
> the only way to do that is the rerun the parser and rebuild.  This isn't
> a big deal, but could be confusing to the next hacker who's wondering
> why his change is impacting those constructors if he has to rerun the
> parser.  :)
> Please commit with the above changes.  Thanks.
> -- 
> Mike Kestner <mkestner@speakeasy.net>
> _______________________________________________
> Gtk-sharp-list maillist  -  Gtk-sharp-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/gtk-sharp-list