[Gtk-sharp-list] RadioButton api

Mike Kestner mkestner@speakeasy.net
Fri, 09 Jan 2004 10:30:16 -0600

On Thu, 2004-01-08 at 17:26, John Luke wrote:

> After thinking through this some more, I think it is ok to hide the
> group property and methods.  If it proves that we need access to a group
> property, we can add one that gets/sets the group as a RadioButton, but
> I think it wont be necessary.
> Attached updated patch.

Couple of comments.  Since you are hiding all of the RadioButton ctors,
instead of using 6 lines in the metadata, you can get it with one line: 

<attr path="/api/namespace/object[@cname='GtkRadioButton']/constructor"

Second.  When removing a metadata line, please make sure that it's
effects are removed from the api.xml file.  There are still a couple of
null_ok attrs left on those constructors in the patch.  Unfortunately,
the only way to do that is the rerun the parser and rebuild.  This isn't
a big deal, but could be confusing to the next hacker who's wondering
why his change is impacting those constructors if he has to rerun the
parser.  :)

Please commit with the above changes.  Thanks.

Mike Kestner <mkestner@speakeasy.net>