[forms-devel] Color.Accent

[Michael Rumpler]

Hi,

 

I created the PR, I'm just not sure about the rebase. Never did that before
and when I ran "git rebase -i master", then it only printed noop and didn't
list my commit. So I don't think that it actually did something.

 

But it was only one commit and one file, so it's really not hard to follow.

 

Cheers,

Michael

 

From: Jason Smith [mailto:jas at microsoft.com] 
Sent: Friday, July 22, 2016 6:21 PM
To: Michael Rumpler <michael at mrumpler.at>; forms-devel at lists.dot.net
Subject: RE: [forms-devel] Color.Accent

 

Reading Color.Accent from the current theme would be the preferred approach
:) Thanks!

 

From: forms-devel-bounces at lists.dot.net
<mailto:forms-devel-bounces at lists.dot.net>
[mailto:forms-devel-bounces at lists.dot.net] On Behalf Of Michael Rumpler
Sent: Friday, July 22, 2016 2:57 AM
To: forms-devel at lists.dot.net <mailto:forms-devel at lists.dot.net> 
Subject: [forms-devel] Color.Accent

 

Hi,

 

Color.Accent is used on Android as text and separator color for
TableSections and this cannot be changed. It is also used as default color
for TextCell.TextColor, but this can be set by the user, so it is no
problem.

 

Color.Accent is set to a hardcoded value in Xamarin.Forms.Forms.SetupInit
(in the Platform.Android project) and it cannot be changed by the user.

 

I could do a PR for

-        Making the Color.Accent setter public (so just removing the
"internal")

-        Enhance the logic in SetupInit to read the colorAccent from the
current theme

 

Either would suffice, both would be better.

 

What do you prefer?

 

Regards,

Michael




-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7690 / Virus Database: 4627/12697 - Release Date: 07/28/16
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.dot.net/pipermail/forms-devel/attachments/20160728/3449cbff/attachment.html>