[Monodevelop-patches-list] r2336 - trunk/MonoDevelop/Unused/Gdl

[Lluis Sanchez <lluis@ximian.com>]

Author: lluis
Date: 2005-03-13 07:27:51 -0500 (Sun, 13 Mar 2005)
New Revision: 2336

Modified:
   trunk/MonoDevelop/Unused/Gdl/ChangeLog
   trunk/MonoDevelop/Unused/Gdl/DockItemGrip.cs
   trunk/MonoDevelop/Unused/Gdl/DockMaster.cs
Log:
2005-03-13  Lluis Sanchez Gual  <lluis at novell.com>

	* DockItemGrip.cs, DockMaster.cs: Fix potential memory leaks.



Modified: trunk/MonoDevelop/Unused/Gdl/ChangeLog
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/ChangeLog	2005-03-13 05:06:07 UTC (rev 2335)
+++ trunk/MonoDevelop/Unused/Gdl/ChangeLog	2005-03-13 12:27:51 UTC (rev 2336)
@@ -1,3 +1,7 @@
+2005-03-13  Lluis Sanchez Gual  <lluis at novell.com>
+
+	* DockItemGrip.cs, DockMaster.cs: Fix potential memory leaks.
+
 2005-02-28  John Luke  <john.luke at gmail.com>
 
 	* DockBarButton.cs: new Button wrapper

Modified: trunk/MonoDevelop/Unused/Gdl/DockItemGrip.cs
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/DockItemGrip.cs	2005-03-13 05:06:07 UTC (rev 2335)
+++ trunk/MonoDevelop/Unused/Gdl/DockItemGrip.cs	2005-03-13 12:27:51 UTC (rev 2336)
@@ -77,6 +77,9 @@
 				return item;
 			}
 			set {
+				if (item != null)
+					item.PropertyChanged -= OnPropertyChanged;
+				
 				item = value;
 				item.PropertyChanged += OnPropertyChanged;
 				

Modified: trunk/MonoDevelop/Unused/Gdl/DockMaster.cs
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/DockMaster.cs	2005-03-13 05:06:07 UTC (rev 2335)
+++ trunk/MonoDevelop/Unused/Gdl/DockMaster.cs	2005-03-13 12:27:51 UTC (rev 2336)
@@ -177,7 +177,7 @@
 						EmitNotifyLocked ();
 				}
 				if (unlockedItems.Contains (obj)) {
-					lockedItems.Remove (obj);
+					unlockedItems.Remove (obj);
 					if (Locked != locked)
 						EmitNotifyLocked ();
 				}
@@ -185,6 +185,7 @@
 			
 			if (obj is Dock) {
 				toplevelDocks.Remove (obj);
+				obj.Docked -= OnItemDocked;
 
 				if (obj == controller) {
 					DockObject newController = null;
@@ -219,6 +220,7 @@
 				item.DockItemDragBegin -= OnDragBegin;
 				item.DockItemMotion -= OnDragMotion;
 				item.DockItemDragEnd -= OnDragEnd;
+				item.PropertyChanged -= OnItemPropertyChanged;
 			}
 			
 			// remove the object from the hash if it is there