[Monodevelop-patches-list] r2299 - trunk/MonoDevelop/Unused/Gdl

[John Luke <jluke@cfl.rr.com>]

Author: jluke
Date: 2005-03-06 21:55:59 -0500 (Sun, 06 Mar 2005)
New Revision: 2299

Modified:
   trunk/MonoDevelop/Unused/Gdl/DockLayout.cs
   trunk/MonoDevelop/Unused/Gdl/DockMaster.cs
   trunk/MonoDevelop/Unused/Gdl/DockPaned.cs
   trunk/MonoDevelop/Unused/Gdl/TODO
Log:
update


Modified: trunk/MonoDevelop/Unused/Gdl/DockLayout.cs
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/DockLayout.cs	2005-03-07 02:08:42 UTC (rev 2298)
+++ trunk/MonoDevelop/Unused/Gdl/DockLayout.cs	2005-03-07 02:55:59 UTC (rev 2299)
@@ -134,16 +134,13 @@
 				s.Close ();
 				// minimum validation: test root element
 				if (this.RootNode != null) {
-					// FIXME: I cheated here
 					foreach (XmlNode n in this.RootNode.ChildNodes)
 					{
 						if (n.Name == "layout")
 							layouts.Add (n.Attributes["name"].Value);
 					}
 					UpdateLayoutsModel ();
-					// FIXME: for testing load the default
-					return LoadLayout (null);
-					// return true;
+					return true;
 				}
 				else {
 					doc = null;	
@@ -411,14 +408,12 @@
 		DockObject SetupObject (XmlNode node)
 		{
 			DockObject obj = null;
-			// FIXME: notebooks don't get names ...
 			if (node.Name == "notebook") {
 				DockNotebook dn = new DockNotebook ();
 				dn.Bind (master);
 				dn.FromXml (node);
 				return dn;
 			}
-			// FIXME: paned don't get names ...
 			if (node.Name == "paned") {
 				DockPaned dp = new DockPaned ();
 				dp.Bind (master);
@@ -435,7 +430,6 @@
 				Console.WriteLine ("While loading layout: don't know how to create a dock object whose nick is '{0}'", name);
 			}
 
-			// FIXME: all sorts of unserialization stuff
 			if (obj != null)
 				obj.FromXml (node);
 
@@ -468,8 +462,7 @@
 					if (obj is DockPlaceholder)
 						obj.Detach (false);
 
-					// apply "after" parameters
-					// FIXME:
+					// FIXME: apply "after" parameters
 
 					// add the object to the parent
 					if (parent != null) {
@@ -587,8 +580,7 @@
 		void AddPlaceholder (DockObject obj, Hashtable placeholders)
 		{
 			if (obj is DockPlaceholder) {
-				// FIXME:
-				// add the current placeholder to the list of placeholders for that host
+				// FIXME: add the current placeholder to the list of placeholders for that host
 			}
 		}
 

Modified: trunk/MonoDevelop/Unused/Gdl/DockMaster.cs
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/DockMaster.cs	2005-03-07 02:08:42 UTC (rev 2298)
+++ trunk/MonoDevelop/Unused/Gdl/DockMaster.cs	2005-03-07 02:55:59 UTC (rev 2299)
@@ -161,7 +161,6 @@
 				/* post a layout_changed emission if the item is not automatic
 				 * (since it should be added to the items model) */
 				if (!item.IsAutomatic) {
-					// FIXME: Emit a LayoutChanged event?
 					EmitLayoutChangedEvent ();
 				}
 			}

Modified: trunk/MonoDevelop/Unused/Gdl/DockPaned.cs
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/DockPaned.cs	2005-03-07 02:08:42 UTC (rev 2298)
+++ trunk/MonoDevelop/Unused/Gdl/DockPaned.cs	2005-03-07 02:55:59 UTC (rev 2299)
@@ -62,7 +62,7 @@
 			else
 				Child = new VPaned ();
 			
-			// FIXME: Register signal handlers.						
+			// FIXME: track position to emit layout changed
 												
 			Child.Parent = this;
 			Child.Show ();

Modified: trunk/MonoDevelop/Unused/Gdl/TODO
===================================================================
--- trunk/MonoDevelop/Unused/Gdl/TODO	2005-03-07 02:08:42 UTC (rev 2298)
+++ trunk/MonoDevelop/Unused/Gdl/TODO	2005-03-07 02:55:59 UTC (rev 2299)
@@ -1,6 +1,9 @@
- - layout code
  - restore size/position on de-iconify?
  - fix:
 (<unknown>:21016): Gtk-CRITICAL **: gtk_widget_send_expose: assertion `GTK_WIDGET_REALIZED (widget)' failed
  - proper license headers
  - remove DockParamFlags? it looks useless
+ - improve de-serialization (also use ExportLayoutAttribute?)
+ - "after" properties, ex. restoring Notebook.Page
+ - placeholders in layout store/restore
+ - track paned position