[Monodevelop-patches-list] r2580 - in trunk/MonoDevelop/Core/src/MonoDevelop.Base: . Gui/Dialogs/ReferenceDialog

John Luke <jluke@cfl.rr.com> jluke at mono-cvs.ximian.com
Thu Jun 2 18:52:45 EDT 2005


Author: jluke
Date: 2005-06-02 18:52:44 -0400 (Thu, 02 Jun 2005)
New Revision: 2580

Modified:
   trunk/MonoDevelop/Core/src/MonoDevelop.Base/ChangeLog
   trunk/MonoDevelop/Core/src/MonoDevelop.Base/Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs
Log:
2005-06-01  John Luke  <john.luke at gmail.com>

        * Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs:
        check GetIterFirst return value to avoid gtk+ assertions
        might fix bug 74445



Modified: trunk/MonoDevelop/Core/src/MonoDevelop.Base/ChangeLog
===================================================================
--- trunk/MonoDevelop/Core/src/MonoDevelop.Base/ChangeLog	2005-06-02 17:30:49 UTC (rev 2579)
+++ trunk/MonoDevelop/Core/src/MonoDevelop.Base/ChangeLog	2005-06-02 22:52:44 UTC (rev 2580)
@@ -1,3 +1,9 @@
+2005-06-01  John Luke  <john.luke at gmail.com>
+
+	* Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs:
+	check GetIterFirst return value to avoid gtk+ assertions
+	might fix bug 74445
+
 2005-06-02  Lluis Sanchez Gual  <lluis at novell.com> 
 
 	* Gui/Pads/SolutionPad/TreeViewPad.cs: Fix warning.

Modified: trunk/MonoDevelop/Core/src/MonoDevelop.Base/Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs
===================================================================
--- trunk/MonoDevelop/Core/src/MonoDevelop.Base/Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs	2005-06-02 17:30:49 UTC (rev 2579)
+++ trunk/MonoDevelop/Core/src/MonoDevelop.Base/Gui/Dialogs/ReferenceDialog/SelectReferenceDialog.cs	2005-06-02 22:52:44 UTC (rev 2580)
@@ -42,7 +42,7 @@
 			get {
 				ProjectReferenceCollection referenceInformations = new ProjectReferenceCollection();
 				Gtk.TreeIter looping_iter;
-				if (refTreeStore.GetIterFirst (out looping_iter) == false) {
+				if (!refTreeStore.GetIterFirst (out looping_iter)) {
 					return referenceInformations;
 				}
 				do {
@@ -124,7 +124,8 @@
 		public void RemoveReference (ReferenceType referenceType, string referenceName, string referenceLocation)
 		{
 			Gtk.TreeIter looping_iter;
-			refTreeStore.GetIterFirst (out looping_iter);
+			if (!refTreeStore.GetIterFirst (out looping_iter))
+				return;
 			do {
 				if (referenceLocation == (string)refTreeStore.GetValue (looping_iter, 2)) {
 					refTreeStore.Remove (ref looping_iter);
@@ -136,7 +137,8 @@
 		public void AddReference(ReferenceType referenceType, string referenceName, string referenceLocation)
 		{
 			Gtk.TreeIter looping_iter;
-			refTreeStore.GetIterFirst (out looping_iter);
+			if (!refTreeStore.GetIterFirst (out looping_iter))
+				return;
 			do {
 				try {
 					if (referenceLocation == (string)refTreeStore.GetValue (looping_iter, 2) && referenceName == (string)refTreeStore.GetValue (looping_iter, 0)) {




More information about the Monodevelop-patches-list mailing list