[Monodevelop-patches-list] r1298 - in trunk/MonoDevelop/src: AddIns/DisplayBindings/SourceEditor AddIns/DisplayBindings/SourceEditor/Gui Main/Base Main/Base/Gui/Pads/ClassScout

[commit-watcher at mono-cvs.ximian.com]

Author: tberman
Date: 2004-03-29 19:45:22 -0500 (Mon, 29 Mar 2004)
New Revision: 1298

Modified:
   trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog
   trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorDisplayBinding.cs
   trunk/MonoDevelop/src/Main/Base/ChangeLog
   trunk/MonoDevelop/src/Main/Base/Gui/Pads/ClassScout/ClassScout.cs
Log:
fixing double click issues under 2.4 and all row_activated issues in the class browser with regards to focus...

edd, this is your bugfix buddy :)


Modified: trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog
===================================================================
--- trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog	2004-03-29 22:24:32 UTC (rev 1297)
+++ trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog	2004-03-30 00:45:22 UTC (rev 1298)
@@ -1,5 +1,11 @@
 2004-03-29  Todd Berman  <tberman at sevenl.net>
 
+	* Gui/SourceEditorDisplayBinding.cs: second half of the double clicking
+	not setting focus properly, in specific this is a gtk+ 2.4 regression,
+	bug filed: http://bugzilla.gnome.org/show_bug.cgi?id=138458
+
+2004-03-29  Todd Berman  <tberman at sevenl.net>
+
 	* Gui/SourceEditorDisplayBinding.cs: properly mark IsReadOnly
 
 2004-03-28  Todd Berman  <tberman at sevenl.net>

Modified: trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorDisplayBinding.cs
===================================================================
--- trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorDisplayBinding.cs	2004-03-29 22:24:32 UTC (rev 1297)
+++ trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorDisplayBinding.cs	2004-03-30 00:45:22 UTC (rev 1298)
@@ -133,7 +133,18 @@
 			
 			se.Buffer.PlaceCursor (itr);		
 			se.View.ScrollMarkOnscreen (se.Buffer.InsertMark);
+			Gtk.Timeout.Add (20, new Gtk.Function (changeFocus));
+		}
+
+		//This code exists to workaround a gtk+ 2.4 regression/bug
+		//
+		//The gtk+ 2.4 treeview steals focus with double clicked
+		//row_activated.
+		// http://bugzilla.gnome.org/show_bug.cgi?id=138458
+		bool changeFocus ()
+		{
 			se.View.GrabFocus ();
+			return false;
 		}
 		
 		public void GotoMatchingBrace ()

Modified: trunk/MonoDevelop/src/Main/Base/ChangeLog
===================================================================
--- trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-03-29 22:24:32 UTC (rev 1297)
+++ trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-03-30 00:45:22 UTC (rev 1298)
@@ -1,5 +1,10 @@
 2004-03-29  Todd Berman  <tberman at sevenl.net>
 
+	* Gui/Pads/ClassScout/ClassScout.cs: partial fix to bug with double
+	clicking not setting focus properly.
+
+2004-03-29  Todd Berman  <tberman at sevenl.net>
+
 	* Commands/RunCommands.cs: When you run, you need to make sure the
 	compile completed properly.
 	* Gui/Workbench/Layouts/SdiWorkspaceWindow.cs: Mark file/project dirty

Modified: trunk/MonoDevelop/src/Main/Base/Gui/Pads/ClassScout/ClassScout.cs
===================================================================
--- trunk/MonoDevelop/src/Main/Base/Gui/Pads/ClassScout/ClassScout.cs	2004-03-29 22:24:32 UTC (rev 1297)
+++ trunk/MonoDevelop/src/Main/Base/Gui/Pads/ClassScout/ClassScout.cs	2004-03-30 00:45:22 UTC (rev 1298)
@@ -182,7 +182,6 @@
 					if (content is IPositionable) {
 						if (tag.Line > 0) {
 							((IPositionable)content).JumpTo(tag.Line - 1, 0);
-							content.Control.GrabFocus();
 						}
 					}
 				}