[Monodevelop-patches-list] r1254 - in trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor: . CodeCompletion Gui

[commit-watcher at mono-cvs.ximian.com]

Author: tberman
Date: 2004-03-25 23:54:18 -0500 (Thu, 25 Mar 2004)
New Revision: 1254

Modified:
   trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog
   trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/CodeCompletion/CompletionWindow.cs
   trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorView.cs
Log:
attempt to fix placement yet again.

turns out its an issue with us being too fast for gtk+


Modified: trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog
===================================================================
--- trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog	2004-03-26 03:52:16 UTC (rev 1253)
+++ trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/ChangeLog	2004-03-26 04:54:18 UTC (rev 1254)
@@ -1,5 +1,12 @@
 2004-03-25  Todd Berman  <tberman at sevenl.net>
 
+	* Gui/SourceEditorView.cs: setup completionWindow to be reused properly
+	* CodeCompletion/CompletionWindow.cs: delay a bit before movement to
+	attempt to fix correct placement issues. this goes from working
+	properly 90% of the time to 99% of the time.
+
+2004-03-25  Todd Berman  <tberman at sevenl.net>
+
 	* Gui/SourceEditorView.cs:
 	* CodeCompletion/TextUtilities.cs:
 	* CodeCompletion/CompletionWindow.cs:

Modified: trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/CodeCompletion/CompletionWindow.cs
===================================================================
--- trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/CodeCompletion/CompletionWindow.cs	2004-03-26 03:52:16 UTC (rev 1253)
+++ trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/CodeCompletion/CompletionWindow.cs	2004-03-26 04:54:18 UTC (rev 1254)
@@ -236,9 +236,12 @@
 			
 			int tx, ty;
 			control.GdkWindow.GetOrigin (out tx, out ty);
+			//Console.WriteLine ("Moving to: " + (tx + wx) + " . " + (ty + wy));
+			System.Threading.Thread.Sleep (100);
 			Move (tx + wx, ty + wy);
 			listView.Selection.Changed += new EventHandler (RowActivated);
 			ShowAll ();
+			//GdkWindow.Move (tx + wx, ty + wy);
 		}
 		
 		string fileName;

Modified: trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorView.cs
===================================================================
--- trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorView.cs	2004-03-26 03:52:16 UTC (rev 1253)
+++ trunk/MonoDevelop/src/AddIns/DisplayBindings/SourceEditor/Gui/SourceEditorView.cs	2004-03-26 04:54:18 UTC (rev 1254)
@@ -25,9 +25,20 @@
 		internal IFormattingStrategy fmtr;
 		SourceEditorBuffer buf;
 		int lineToMark = -1;
-		CompletionWindow completionWindow;
+		CompletionWindow completionWnd;
 		bool codeCompleteEnabled;
-		
+
+		CompletionWindow completionWindow {
+			set {
+				if (completionWnd != null) {
+					completionWnd.Destroy ();
+					completionWnd = null;
+				}
+				completionWnd = value;
+			}
+			get { return completionWnd; }
+		}
+
 		public static new GLib.GType GType
 		{
 			get