[Monodevelop-patches-list] r1182 - in trunk/MonoDevelop: . src/Main/Base/Commands

[commit-watcher at mono-cvs.ximian.com]

Author: jba
Date: 2004-03-16 18:51:22 -0500 (Tue, 16 Mar 2004)
New Revision: 1182

Modified:
   trunk/MonoDevelop/ChangeLog
   trunk/MonoDevelop/src/Main/Base/Commands/MenuItemBuilders.cs
Log:
fixed external tool launching in correct WorkingDirectory
and also made it not parse the tool command (bug 53311).

Modified: trunk/MonoDevelop/ChangeLog
===================================================================
--- trunk/MonoDevelop/ChangeLog	2004-03-16 21:11:16 UTC (rev 1181)
+++ trunk/MonoDevelop/ChangeLog	2004-03-16 23:51:22 UTC (rev 1182)
@@ -1,3 +1,10 @@
+2004-03-17	John BouAntoun  <jba-mono at optusnet.com.au>
+	
+	* src/Main/Base/Commands/MenuItemBuilders.cs:
+	fixed external tool launching in correct WorkingDirectory
+	and also made it not parse the tool command (bug 53311).
+	Still need to fix prompt for arguments issue.
+
 2004-03-15  John Luke  <jluke at cfl.rr.com>
 	
 	* monodevelop.in: fix LD_LIBRARY_PATH
@@ -33,7 +40,7 @@
 	* configure.in: Add GDLDOCK_{CFLAGS,LIBS} variables for building
 	GdlDock.
 
-2004-03-05  John BouAntoun  <jba-mono at optusnet.com.au>
+2004-03-11  John BouAntoun  <jba-mono at optusnet.com.au>
 	
 	* src/Main/Base/Commands/ProjectBrowserCommands/CombineNodeCommands.cs:
 	Made it so adding any new nodes to projectbrowserview 

Modified: trunk/MonoDevelop/src/Main/Base/Commands/MenuItemBuilders.cs
===================================================================
--- trunk/MonoDevelop/src/Main/Base/Commands/MenuItemBuilders.cs	2004-03-16 21:11:16 UTC (rev 1181)
+++ trunk/MonoDevelop/src/Main/Base/Commands/MenuItemBuilders.cs	2004-03-16 23:51:22 UTC (rev 1182)
@@ -134,7 +134,7 @@
 			for (int i = 0; i < ToolLoader.Tool.Count; ++i) {
 				if (item.Text == ToolLoader.Tool[i].ToString()) {
 					ExternalTool tool = (ExternalTool)ToolLoader.Tool[i];
-					string command = stringParserService.Parse(tool.Command);
+					string command = tool.Command;
 					string args    = stringParserService.Parse(tool.Arguments);
 					Console.WriteLine("command : " + command);
 					Console.WriteLine("args    : " + args);
@@ -146,8 +146,12 @@
 							startinfo = new ProcessStartInfo(command, args);
 						}
 						
-						startinfo.WorkingDirectory = tool.InitialDirectory;
+						startinfo.WorkingDirectory = stringParserService.Parse(tool.InitialDirectory);
+						
+						// FIXME: need to find a way to prompt for the user arguments						
+						// FIXME: need to find a way to wire the console output into the output window if specified
 						Process.Start(startinfo);
+						
 					} catch (Exception ex) {
 						IMessageService messageService =(IMessageService)ServiceManager.Services.GetService(typeof(IMessageService));
 						messageService.ShowError(ex, "External program execution failed.\nError while starting:\n '" + command + " " + args + "'");