[Monodevelop-patches-list] r1412 - in trunk/MonoDevelop/src/Main/Base: . Commands Gui/Dialogs

[commit-watcher at mono-cvs.ximian.com]

Author: jluke
Date: 2004-04-07 23:31:41 -0400 (Wed, 07 Apr 2004)
New Revision: 1412

Modified:
   trunk/MonoDevelop/src/Main/Base/ChangeLog
   trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs
   trunk/MonoDevelop/src/Main/Base/Gui/Dialogs/TipOfTheDay.cs
Log:
 	* Gui/Dialogs/TipOfTheDay.cs: remove IDisposable and call Hide and Dispose
	instead of Destroy on the window, remove some unneccesary public things
	* Commands/HelpCommand.cs: revert addition of using () {} to tipoftheday



Modified: trunk/MonoDevelop/src/Main/Base/ChangeLog
===================================================================
--- trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-04-08 02:20:31 UTC (rev 1411)
+++ trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-04-08 03:31:41 UTC (rev 1412)
@@ -4,6 +4,9 @@
 	* Gui/Dialogs/SharpDevelopAboutPanels.cs: rearrange the copyright, license,
 	sponsorship, and version information.  Add back info about SharpDevelop and
 	AlphaSierraPapa
+	* Gui/Dialogs/TipOfTheDay.cs: remove IDisposable and call Hide and Dispose
+	instead of Destroy on the window, remove some unneccesary public things
+	* Commands/HelpCommand.cs: revert addition of using () {} to tipoftheday
 
 2004-04-07  Todd Berman  <tberman at sevenl.net>
 

Modified: trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs
===================================================================
--- trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs	2004-04-08 02:20:31 UTC (rev 1411)
+++ trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs	2004-04-08 03:31:41 UTC (rev 1412)
@@ -86,9 +86,8 @@
 	{
 		public override void Run()
 		{
-			using (TipOfTheDayWindow totdw = new TipOfTheDayWindow ()) {
-				totdw.Show ();
-			}
+			TipOfTheDayWindow totdw = new TipOfTheDayWindow ();
+			totdw.Show ();
 		}
 	}
 	

Modified: trunk/MonoDevelop/src/Main/Base/Gui/Dialogs/TipOfTheDay.cs
===================================================================
--- trunk/MonoDevelop/src/Main/Base/Gui/Dialogs/TipOfTheDay.cs	2004-04-08 02:20:31 UTC (rev 1411)
+++ trunk/MonoDevelop/src/Main/Base/Gui/Dialogs/TipOfTheDay.cs	2004-04-08 03:31:41 UTC (rev 1412)
@@ -16,7 +16,7 @@
 
 namespace MonoDevelop.Gui.Dialogs
 {
-	public class TipOfTheDayWindow : IDisposable
+	public class TipOfTheDayWindow
 	{
  		ResourceService resourceService = (ResourceService)ServiceManager.Services.GetService (typeof (IResourceService));
  		PropertyService propertyService = (PropertyService)ServiceManager.Services.GetService (typeof (PropertyService));
@@ -56,11 +56,6 @@
 			tipTextview.Buffer.InsertAtCursor (tips[currentTip]);
 		}
 
-		public void Dispose ()
-		{
-			tipOfTheDayWindow.Dispose ();
-		}
-
 		private void ParseTips (XmlElement el)
 		{
  			StringParserService stringParserService = (StringParserService)ServiceManager.Services.GetService (typeof (StringParserService));
@@ -74,27 +69,29 @@
  			currentTip = (new Random ().Next ()) % nodes.Count;
 		}
 
-		public void OnNoshow (object obj, EventArgs args)
+		void OnNoshow (object obj, EventArgs args)
 		{
 			propertyService.SetProperty ("MonoDevelop.Gui.Dialog.TipOfTheDayView.ShowTipsAtStartup",
 						    noshowCheckbutton.Active);
 		}
 
-		public void OnNext (object obj, EventArgs args)
+		void OnNext (object obj, EventArgs args)
 		{
 			tipTextview.Buffer.Clear ();
 			currentTip = ++currentTip % tips.Length;
 			tipTextview.Buffer.InsertAtCursor (tips[currentTip]);
 		}
 
-		public void OnClose (object obj, EventArgs args)
+		void OnClose (object obj, EventArgs args)
 		{
-			tipOfTheDayWindow.Destroy ();
+			tipOfTheDayWindow.Hide ();
+			tipOfTheDayWindow.Dispose ();
 		}
 
-		public void OnDelete (object obj, DeleteEventArgs args)
+		void OnDelete (object obj, DeleteEventArgs args)
 		{
-			tipOfTheDayWindow.Destroy ();
+			tipOfTheDayWindow.Hide ();
+			tipOfTheDayWindow.Dispose ();
 		}
 
 		public void Show ()