[Monodevelop-patches-list] r1392 - in trunk/MonoDevelop/src/Main/Base: . Commands

commit-watcher at mono-cvs.ximian.com commit-watcher at mono-cvs.ximian.com
Mon Apr 5 20:34:53 EDT 2004


Author: jluke
Date: 2004-04-05 20:34:53 -0400 (Mon, 05 Apr 2004)
New Revision: 1392

Modified:
   trunk/MonoDevelop/src/Main/Base/ChangeLog
   trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs
Log:
* Commands/HelpCommands.cs: make sure dispose is called on the
       tip of the day and about dialogs


Modified: trunk/MonoDevelop/src/Main/Base/ChangeLog
===================================================================
--- trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-04-05 22:13:40 UTC (rev 1391)
+++ trunk/MonoDevelop/src/Main/Base/ChangeLog	2004-04-06 00:34:53 UTC (rev 1392)
@@ -2,6 +2,8 @@
 
 	* Gui/BrowserDisplayBinding/HtmlViewPane.cs:
 	* Gui/BrowserDisplayBinding/BrowserDisplayBinding.cs: small cleanups
+	* Commands/HelpCommands.cs: make sure dispose is called on the
+	tip of the day and about dialogs
 
 2004-04-04  Todd Berman  <tberman at sevenl.net>
 

Modified: trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs
===================================================================
--- trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs	2004-04-05 22:13:40 UTC (rev 1391)
+++ trunk/MonoDevelop/src/Main/Base/Commands/HelpCommands.cs	2004-04-06 00:34:53 UTC (rev 1392)
@@ -10,7 +10,6 @@
 using System.IO;
 using System.Collections;
 using Gtk;
-using GtkSharp;
 
 using MonoDevelop.Core.AddIns.Codons;
 using MonoDevelop.Core.Properties;
@@ -40,7 +39,7 @@
 	{
 		public override void Run()
 		{
-			ViewGPLDialog vgd = new ViewGPLDialog();
+			ViewGPLDialog vgd = new ViewGPLDialog ();
 		}
 	}
 	
@@ -78,7 +77,7 @@
 				Process.Start(file);
 			} catch (Exception) {
 				IMessageService messageService =(IMessageService)ServiceManager.Services.GetService(typeof(IMessageService));
-				messageService.ShowError(String.Format (GettextCatalog.GetString ("Can't execute/view {0}\n Please check that the file exists and that you can open this file."), file));
+				messageService.ShowError(String.Format (GettextCatalog.GetString ("Can not execute or view {0}\n Please check that the file exists and that you can open this file."), file));
 			}
 		}
 	}
@@ -87,6 +86,7 @@
 	{
 		public override void Run()
 		{
+			//FIXME: make this a dialog and use Run
 			TipOfTheDayWindow totdw = new TipOfTheDayWindow ();
 			totdw.Show ();
 		}
@@ -96,9 +96,10 @@
 	{
 		public override void Run()
 		{
-			CommonAboutDialog ad = new CommonAboutDialog ();
-			ad.Run ();
-			ad.Hide ();
+			using (CommonAboutDialog ad = new CommonAboutDialog ()) {
+				ad.Run ();
+				ad.Hide ();
+			}
 		}
 	}
 }




More information about the Monodevelop-patches-list mailing list