[MonoDevelop] Contributing to Monodevelop: ViMode

[Ryan]

Thanks for the response!
Sorry about the number of commits, I wrapped a ton of changes in this 
pull request - and in the future I can try to keep my pull requests more 
concise.
"Ad-hoc and messy" kinda describes my method for implementing 
multipliers - my approach is functional but somewhat quick and dirty.

If you'd like, I could go back over it and see if I can find a cleaner 
way to do it.
I had an idea, but it would have involved refactoring much of ViMode.cs, 
especially the handleKeypress method.
My current approach attempted to leave existing code untouched as much 
as possible, but may not be the best long-term solution.

Let me know what you think - and no rush on the review. I can see you 
get a lot of pull requests so just let me know when you get to it.
Thanks,
Ryan

On 06/10/2013 10:15 AM, Michael Hutchinson wrote:
>
> Hi Ryan,
>
> Contributions to the vi mode would be fantastic. I haven't really had 
> time to work much on it since I wrote it. I did start a rewrite to 
> correct some early design decisions that mean that storing state 
> between keystrokes is ad-hoc and messy but I never finished. All the 
> new code is in git but unused. And I don't think the rewrite approach 
> was right either, but I'm still unsure how to do it best...
>
> I assume this pull request is yours? If so, thanks!
>
> https://github.com/mono/monodevelop/pull/293
>
> I'm sorry I haven't had time to review it yet - the number of commits 
> is a bit daunting, and it need some coding style cleanup. I'll get 
> round to it, I promise!
>
> - Michael
>
> On Jun 4, 2013 5:17 PM, "Ryan" <murphyslaw480 at gmail.com 
> <mailto:murphyslaw480 at gmail.com>> wrote:
>
>     Hi all,
>     I'm interested in trying to contribute to the Monodevelop project,
>     specifically the embedded vi editor mode.
>     I've found this list of TODO items:
>     http://monodevelop.com/Developers/Tasks/Source_Editing/Vi_Mode
>     but I'm not sure if its up to date. The current master branch of
>     monodevelop doesn't seem to have any of these features but I don't
>     know if somebody else is implementing them yet.
>     Does anyone know the current status of ViMode in Monodevelop?
>
>     Here are some of the features I'd like to implement:
>     1. Multipliers (e.g. 5dd, 4>>, 3cw, 7@@)
>     2. Goto line (44gg)
>     3. Word end movement (e, E)
>     4. Inner/Outer motions (ci{, da])
>     5. Find motion (f)
>
>     I already have tentative solutions for 1-3, but they aren't very
>     thoroughly tested, as only I've been using them.
>     Let me know if these are already in the works / implemented
>     somewhere else.
>
>     Also, if anyone has any general advice with regards to
>     contributing to monodevelop, I would appreciate it. I'm somewhat
>     familiar with Git but have never contributed to a large
>     open-source project before.
>
>     Thanks,
>
>     Ryan
>     _______________________________________________
>     Monodevelop-list mailing list
>     Monodevelop-list at lists.ximian.com
>     <mailto:Monodevelop-list at lists.ximian.com>
>     http://lists.ximian.com/mailman/listinfo/monodevelop-list
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/monodevelop-list/attachments/20130610/82e9dd1d/attachment-0001.html>