[MonoDevelop] New Patch to MonoDevelop.WebReference Addin

[Luciano _]

Thanks Lluis. 

I will make all of you suggest. 
2 comments:
- The same for calls to StatusBar.ShowMessage: I didn't this, but i will change to use GettextCatalog
- The last-one, i've got bug report on this, and i'm working with latest MD from svn. So i will wait to this bug get fixed and then i will make a new patch using Stetic.

Bye
Lucian0


----------------------------------------
> From: lluis at novell.com
> To: lnc19 at hotmail.com
> Date: Mon, 3 Nov 2008 18:10:50 -0500
> CC: monodevelop-list at lists.ximian.com
> Subject: Re: [MonoDevelop] New Patch to MonoDevelop.WebReference Addin
> 
> Hi,
> 
> Thanks for the patch. Here are some comments:
> 
>       * In AddUrlToConfiguration, please use SelectSingleNode to look
>         for an existing url property. It will simplify the code.
>       * Don't generate C# specific code with CodeSnippetStatement.
>       * Remove the debug Console.WriteLine you introduced.
>       * Messages such as "¿Are you sure you want to delete Web
>         Reference?" should be queried using GettextCatalog, so they can
>         be properly translated. Also, remove the ¿.
>       * The same for calls to StatusBar.ShowMessage
>       * Modify the window using the Designer. If it doesn't work for
>         you, please update to latest MD. 
> 
> Lluis.
> 
> El dl 03 de 11 de 2008 a les 00:29 +0000, en/na Luciano _ va escriure:
>> Hi:
>>      I attach 2 files:
>> 
>>      1) A screenshot of a new future (MonoDevelop.WebReference).
>>      2) The patch.
>> 
>> Explanation has two parts:
>> 
>> 1) A minor "change" to delete command: Confirm Dialog when deleting a WebReference and the same for the "Delete All Reference".
>> 
>> 2) The second part, and bigger, is a Future: with this patch WebReference let you select a Project to store the URL in the project app.config file. If the file (app.config) doesn't exists, it is created automatically with this key, if exists, and you have more keys in this file, it let you select one previous added key or add new one. If you update a WebReference that has a "Key" in the app.config file assigned and proxy was generated against this key, it re-creates the proxy class with this configuration reference.
>> I did this configuration per-project and not for the selected project beacause some times you've a project which is a library and you don't want to store the URL in this app.Config file, beacause is not the right one, you want to store it in the main Exe file or some other project. If you select a config key, the proxy class gets a new Constructor like:
>> 
>> public MyWebServices (bool useConfig)
>> {
>>     ...Config Managment here...
>> }
>> 
>> If you don't use this future, the web reference Url works like before.
>> 
>> Please, someone could review/commit it ?
>> 
>> Lucian0
>> 
>> 
>> 
>> _________________________________________________________________
>> Reveal your inner athlete and share it with friends on Windows Live.
>> http://revealyourinnerathlete.windowslive.com?locale=en-us&ocid=TXT_TAGLM_WLYIA_whichathlete_us
>> _______________________________________________ Monodevelop-list mailing list Monodevelop-list at lists.ximian.com http://lists.ximian.com/mailman/listinfo/monodevelop-list
> 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list

_________________________________________________________________
Got Game? Win Prizes in the Windows Live Hotmail Mobile Summer Games Trivia Contest
http://www.gowindowslive.com/summergames?ocid=TXT_TAGHM