[MonoDevelop] [Fwd: Re: patch for 4 minor files (gpl -> mit)]

Lluis Sanchez Gual lluis at novell.com
Thu Jun 5 07:43:28 EDT 2008


El dv 30 de 05 del 2008 a les 09:46 +0200, en/na Carlo Kok va escriure:
> 
> Carlo Kok wrote:
> > Rewrote them from scratch while keeping the public/protected interface 
> > compatible.
> 
> fixed spacing and layout according to the guidelines.
> 
> * Dropped IService & all references to it replacing them with a base
> "AbstractService" class.

Please use just 'Service'. The 'Abstract' prefix does not convey any
useful information here.

Also, InitializeService and UnloadService should be 'internal
protected', since they are not meant to be called by classes other than
the ServiceManager.

> 
> * dropped IDocumentationService

Why drop it? just remove the ISevice inheritance, which never should
have been there anyway.

> * created a new AbstractDocumentationService class that descends from
> AbstractService
> 
> * Fixed all references to IDocumentationService and replaced them with
> the AbstractDocumentationService
> * Dropped GuiSyncAbstractService as nothing was using it
> * Introduced a new static ServiceManager class

With the above changes, it looks good. Thanks!
Lluis.




More information about the Monodevelop-list mailing list