[MonoDevelop] [patch] fix project ID referencing

[Lluis Sanchez Gual]

El dv 18 de 07 de 2008 a les 17:45 -0700, en/na Casey Marshall va
escriure:
> No comments on this?
> 
> On Wed, 2008-07-09 at 16:45 -0700, Casey Marshall wrote:
> > On Wed, 2008-07-09 at 15:53 -0700, Casey Marshall wrote:
> > > For msbuild files, MonoDevelop would write out project references with
> > > the wrong project ID -- it looks like it used the ID of the current
> > > project, not the referenced one.
> > > 
> > > Patch attached (generated in main/src/core/MonoDevelop.Projects).
> > > 
> > > 2008-07-09  Casey Marshall  <cmarshall at pacificbiosciences.com>
> > > 
> > > 	* MSBuildProjectHandler.cs (Save): use the referenced project's
> > > 	ID, not our ID.
> > > 
> > > Released under the MIT/X11 license, though it's trivial.

This has been committed. Thanks!

> > > 
> > > Thanks.
> > 
> > Here's one additional change to the same file: this makes MD respect the
> > `RequiredTargetFramework' value that Visual Studio 2008 places in
> > certain GAC references.

The correct fix is to add RequiredTargetFramework to the list of
unsupported msbuild properties (ExtendedMSBuildProperties). That's now
fixed.

> > 
> > Now modifying an msbuild file in MonoDevelop is only changing two things
> > that it shouldn't, for me: the TargetFrameworkVersion value (it replaces
> > v3.5 with v2.0) and certain assembly references get modified (the
> > "processorArchitecture=MSIL" thing gets removed, and a
> > PublicKeyToken=... gets added; though that's hardly a big deal).
> > 
> > 2008-07-09  Casey Marshall  <cmarshall at pacificbiosciences.com>
> > 
> > 	* MSBuildProjectHandler.cs (Load): save the 
> > 	`RequiredTargetFramework' metadata.
> > 	(Save): use the referenced project's ID, not our ID; write out 
> > 	`RequiredTargetFramework' metadata if it was set.
> > 
> > Thanks.
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list