[MonoDevelop] Proposed patch for bug 336368
m.j.hutchinson at gmail.com
Mon Oct 29 21:08:09 EDT 2007
On 10/29/07, Marcos Marín <marcosmarin at gmail.com> wrote:
> The attached patch fixes bug 336368. It moves all the threading from
> ProjectNodeBuilderExtension to TagDatabaseManager, the UpdateFileTags now
> only enqueues the file and a thread running in the background constantly
> checks the queue for new jobs every second.
> Would appreciate some feedback and whether it is ok for me to commit and
> mark the bug as resolved.
More a question than a problem, but have you considered whether it's
safe for DoUpdateFileTags to operate from another thread, given that
it operates on a project and the tag database?
Also, it might be a good idea to close the thread when the queue is
empty. UpdateFileTags could re-launch the thread if the queue is
empty, then the thread could run until it empties the queue, and exit.
I'll take a better look at it tomorrow.
More information about the Monodevelop-list