[MonoDevelop] Mini-patch for fixing cosmetic UI messages

[Jacob Ilsø Christensen]

On 6/28/07, "Andrés G. Aragoneses [ knocte ]" <knocte at gmail.com> wrote:
> Jacob Ilsø Christensen escribió:
> > On 6/26/07, "Andrés G. Aragoneses [ knocte ]" <knocte at gmail.com> wrote:
> >> Lluis Sanchez escribió:
> >>> El dl 25 de 06 del 2007 a les 16:53 +0200, en/na "Andrés G. Aragoneses
> >>> [ knocte ]" va escriure:
> >>>> Thanks for reviewing.
> >>>>
> >>>> Lluis Sanchez escribió:
> >>>>> It looks ok, although the change in ClientCertificatePasswordDialog.cs
> >>>>> should be done in the gui.stetic file too.
> >>>> I've reworked the patch to fix that, and I also added:
> >>>>
> >>>> - Removal of page# texts from l10n that they don't seem to be shown.
> >>>> - Replace some gtk# references on the MDP because AFAIK we haven't
> >>>> switched to 2.10 yet, have we? (This changes were made by MD
> >>>> automatically when opening its own project.)
> >>> It looks ok.
> >> Thanks, can you commit it then? No SVN account.
> >
> > Hi.
> >
> > I tried out your patch but could not get MD to run after applying it.
> >
> > This seems to be the issue:
> >
> > Index: Core/src/MonoDevelop.Ide/MonoDevelop.Ide.addin.xml
> > ===================================================================
> > --- Core/src/MonoDevelop.Ide/MonoDevelop.Ide.addin.xml  (revision 80893)
> > +++ Core/src/MonoDevelop.Ide/MonoDevelop.Ide.addin.xml  (working copy)
> > @@ -540,8 +540,7 @@
> >                 <Command id =
> > "MonoDevelop.Ide.Commands.ViewCommands.CollapseAllTreeNodes"
> >                                 _label = "Collapse All Nodes" />
> >                 <Command id =
> > "MonoDevelop.Ide.Commands.ViewCommands.OpenWithList"
> > -                               type = "array"
> > -                               _label = "OpenWithList" />
> > +                               type = "array" />
> >
> >                 <!-- ToolCommands -->
> >
> > When I launch MD it complains about _label.
> >
> > Regards,
> > Jacob
> >
>
> Hugh, you're right (thanks for testing). What I don't see is the need
> for that label, because it seems not to appear in the UI. Then the
> solutions I guess are:
>
> 1. Leave it as is, the consequence would be to still having the bogus
> label "OpenWithList" in the code and being found when translating MD.
> 2. Put a better message, like "List of applications to open with".
> 3. Drop the need of any label attribute on command XML tags.
> 4. Drop the need of _label attribute and allow a label alternative
> attribute (for cases like this where we don't need to translate).
>
> What's best?

Well, as the label is not used for anything I don't vote for 1 or 2. I
think I like 3 the best as some commands seemingly do not need a label
at all.

> Regards,
>
>         Andrés  [ knocte ]
>
> --
>
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list
>