[MonoDevelop] Search for parent changelogs

Lluis Sanchez lluis at ximian.com
Wed Jul 4 06:36:03 EDT 2007


> > >
> > > What I want to do is add a button named something like Show Affected
> > > ChangeLogs. This will show a dialog where you can see what ChangeLogs
> > > will be affected by the commit and what content will be added to them.
> > > Sounds like a good approach?
> >
> > Yes, it sounds good. In any case, the commit dialog should show a
> > summary of which changelogs are going to change, and then give more
> > detail when clicking on that button.
> 
> Actually I was planning on only showing the affected ChangeLogs in the
> dialog when clicking the button as there may be many affected
> ChangedLogs.

Well, you don't have to show all affected changelogs, just a summary.
For example, if only one ChangeLog is going to be updated, show it. If
there are more than one, you can just show something like "3 ChangeLog
files will be updated". If there are some entries for which a ChangeLog
could not be found, show a warning in bold red. This summary will give
the user the confidence that everything is being correctly done, without
having to click on that button at every commit.

> 
> > >
> > > The existing CommitDialogExtensionWidget takes a ChangeSet as argument
> > > in the Initialize method. The problem is that this ChangeSet is not
> > > necessarily the same as that which will be committed as only selected
> > > files will be included.
> >
> > The commit dialog does not currently allow selecting which files to
> > commit. All files in the change set will be committed. So that should
> > not be a problem.
> 
> Is that true? When looking at the code in CommitDialog.OnResponse
> files that are not selected are removed from the ChangeSet or am I
> looking the wrong place?

The code is there, but it is not being used. For now you can assume that
the ChangeSet won't change.

> 
> > > So the "Show Affected ChangeLogs" might show
> > > incorrect information. Should we add an event to the CommitDialog so
> > > extensions can listen for selection changes? Also when selecting files
> > > in the CommitDialog the commit message does not change accordingly
> > > which I guess it should. Should it not?
> > >
> > > > > If yes is it ok to commit or is
> > > > > it better to wait for the complete patch?
> > > >
> > > > Yes, it's better to wait for a complete working patch.
> > > >
> > > > Thanks!
> > > > Lluis.
> > > >
> > > >
> > > >
> >
> >
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list



More information about the Monodevelop-list mailing list