[MonoDevelop] [PATCH] Fix improper member node command handling
Lluis Sanchez
lluis at ximian.com
Sun Jul 1 11:05:51 EDT 2007
El dj 28 de 06 del 2007 a les 19:33 +0530, en/na Balaji Rao va escriure:
> On Thu, Jun 28, 2007 at 12:29:29AM +0200, Lluis Sanchez wrote:
> > Hi!
> >
> > I think that MemberNodeCommandHandler should use
> > IdeApp.ProjectOperations.JumpToDeclaration () to open the file. I don't
> > know if JumpToDeclaration() will work for the case that your patch fixes
> > though. You can try it, and if it doesn't maybe you can apply the patch
> > there.
> >
> Fixed it. Is it ok now ?
Not yet:
* Insted of "typeof(IField).IsInstanceOfType(mem)" please use "mem
is IField".
* To be consistent with the surrounding code, the "file=
c.Region.FileName" call should be "file = GetClassFileName (c)".
* The method CanJumpToDeclaration should be in sync with
JumpToDeclaration.
* The patch is missing the corresponding ChangeLog entries.
Thanks,
Lluis.
> > Lluis.
> Regards,
> Balaji Rao
> >
> > El dt 26 de 06 del 2007 a les 16:07 +0530, en/na Balaji Rao va
> > escriure:
> > > Hello guys,
> > >
> > > This patch fixes improper node command handling incase of partial
> > > classes.
> > > _______________________________________________
> > > Monodevelop-list mailing list
> > > Monodevelop-list at lists.ximian.com
> > > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> >
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list
More information about the Monodevelop-list
mailing list