[MonoDevelop] PATCH: Crash in POEditorWidget (MonoDevelop.Gettext addin)

[Rafael Teixeira]

I was experiencing this crash:

(MonoDevelop:21122): Gtk-CRITICAL **: gtk_text_iter_set_line_offset:
assertion `char_on_line <= chars_in_line' failed
System.NullReferenceException: Object reference not set to an instance
of an object
  at MonoDevelop.Gettext.POEditorWidget.EditEntry
(MonoDevelop.Gettext.CatalogEntry entry) [0x00000]
  at MonoDevelop.Gettext.POEditorWidget.RemoveEntryByString
(System.String msgstr) [0x00000]
  at MonoDevelop.Gettext.POEditorWidget.RemoveEntry
(MonoDevelop.Gettext.CatalogEntry entry) [0x00000]
  at MonoDevelop.Gettext.POEditorWidget+<>c__CompilerGenerated1.<>c__AnonymousMethod13
(System.Object +7, System.EventArgs +8) [0x00000]
  at (wrapper delegate-invoke)
System.MulticastDelegate:invoke_void_object_EventArgs
(object,System.EventArgs)
  at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr gch) [0x00000]
  at (wrapper native-to-managed) GLib.Signal:voidObjectCallback (intptr,intptr)
  at <0x00000> <unknown method>
  at (wrapper managed-to-native) Gtk.Application:gtk_main ()
  at Gtk.Application.Run () [0x00000]
  at MonoDevelop.Ide.Gui.IdeApp.Run () [0x00000]
  at MonoDevelop.Ide.Gui.IdeStartup.Run (System.String[] args) [0x00000]
  at MonoDevelop.Core.ApplicationService.StartApplication
(System.String appId, System.String[] parameters) [0x00000]


when trying to Delete a translation entry using the context menu
'delete' command.

I think the newest code added by Mike Krueger, weren't guarded against
parameter 'entry' being null, so I cooked a patch correcting it, that
survived some simple testing.

Can I commit it? Or you Mike, that is currently working on that addin?

Cheers,

-- 
Rafael "Monoman" Teixeira
---------------------------------------
"I myself am made entirely of flaws, stitched together with good intentions."
Augusten Burroughs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: POEditor.diff
Type: text/x-diff
Size: 2646 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20070805/e2d014da/attachment.bin