[MonoDevelop] Goto class dialog

[Lluis Sanchez]

El lun, 18-09-2006 a las 22:11 +0200, Jacob Ilsø Christensen escribió:
> On 9/18/06, Lluis Sanchez <lluis at ximian.com> wrote:
> > El dom, 17-09-2006 a las 22:09 +0200, Jacob Ilsø Christensen escribió:
> > > Hi.
> > >
> > > The attached patch adds a goto class dialog (written in MD's GUI
> > > designer!) to MonoDevelop. The GUI is still a bit crude,
> >
> > it is, indeed ;-)
> 
> I don't hope it's that bad! :-)

I forgot to mention the lack of HIG compliant spacing between the
controls, and the lack of a border in the tree view :-)

> 
> 
> > The ideal design would have an entry box where you would type the name
> > of the class and the dialog would find any class matching the substring
> > (including the namespace in the search). The list of classes needs to be
> > sorted.
> 
> As a matter of fact I started out with an entry box. But since the
> treeview offers the same functionality

Well, not in gtk versions older than gtk 2.4. In any case, what's weird
about the dialog is that it has a label explaining how the dialog works.
It is necessary because it is not so evident that the tree can do that
kind of search. If you put a text box in the top where the user can
enter the class name you don't need to add usage instructions, since
it's very clear how it will work.

However, I admin that doing it in this way is more work, so the tree
search is better than nothing.

>  I deleted it again. The dialog
> is not meant to be used for class searching. It is a "go to
> class"-dialog. 

Yep, so it has to offer you the most efficient way of selecting the
class you want to jump to.

> Searching for classes is better to put in the "Search
> In Files"-dialog IMO. The list should be sorted of course. Just didn't
> do it yet.
> 
> > > but it should
> > > be functional enough.
> > >
> > > A few comments:
> > >
> > > * I could not find a way to make the menu item appear after Goto Line
> > > even though I used insertafter. Maybe due to the order in which the
> > > menu is built?
> >
> > Yeah, that's probably the problem. The search entries are added by the
> > editor add-in, whose commands are loaded after the IDE commands.
> 
> So to make this work I would have to change the editor add-in menu
> items to place them around the ide menu item. Is this issue not a bit
> problematic?

In fact the commands are defined in the IDE, but the menu items are
added by the editor add-in. We could move the menu items to the IDE as
well, this would solve your problem.

Lluis.