[MonoDevelop] Win32 patch

Levi Bard taktaktaktaktaktaktaktaktaktak at gmail.com
Tue Sep 5 13:04:06 EDT 2006


> A couple of comments:
>
>       * MonoPlatformExecutionHandler.cs: Is the workaround not needed
>         anymore?

Not as far as I can ascertain.  The patch works on my gnu/linux system
as well; I'm not sure for what configuration the workaround was
needed.  I think I had the assumption that it was for an older version
of mono.

>       * SystemPackage is not the best place for having an IsWin32
>         property. Maybe we could replace those checks by
>         "Environment.OSVersion.Platform != PlatformId.Unix"? In any
>         case, after using the PathSeparator const and the Uri class for
>         getting absolute paths from uris, there won't be many explicit
>         checks for Win32.

After it seemed apparent that an IsWin32 method or property would be
handy, I performed a cursory scan, and SystemPackage seemed like a
decent place for it to go.  Of course, it can be moved any place that
would be appropriate.  Most of the checks are now in the Autotools
addin - maybe it should go there.  I used IsWin32 rather than an
"isn't unix" check because I thought it would be more flexible, but it
can certainly be changed if this isn't the case.

-- 
Tcsh: Now with higher FPS!
http://www.gnu.org/philosophy/shouldbefree.html


More information about the Monodevelop-list mailing list