[MonoDevelop] Win32 patch

John Luke john.luke at gmail.com
Fri Sep 1 11:15:08 EDT 2006


On Fri, 2006-09-01 at 09:28 -0500, Levi Bard wrote:

> > Also, there seems to be a bunch of whitespace changes which makes it
> > hard to review.
> 
> Sorry, I removed all the \r from the VBBinding file.  Its changes are
> basically the same as for the CSharpBinding.  I can revert the
> whitespace stuff if you prefer.
> 
> > I didn't review the whole thing but here are some:
> > + char splitc = SystemPackage.IsWin32 ? ';' : ':' ;
> >
> > I think just use System.IO.Path.DirectorySeperatorChar for this
> 
> This isn't the DirectorySeparatorChar, this is the char to separate
> different elements in environment variables.  E.g. Unix PATH:
> /bin:/usr/bin   Win32 PATH: c:\windows;c:\windows\system
> 
System.IO.Path.PathSeparator then?
"A platform-specific separator character used to separate path strings
in environment variables."

> 
> > it would probably be better if:
> > 1) we just use '/' unconditionally on windows also (assuming that works
> > like someone told me it does)
> 
> This would require replacing every Path.Combine with foo + '/' + bar
> and every Path.DirectorySeparatorChar with '/'
> 
Hmm, nevermind this then.




More information about the Monodevelop-list mailing list