[MonoDevelop] TaskList patch next round :)

[Lluis Sanchez]

Hi,

The patch looks ok to me. Just a few comments:

In DefaultParserService.cs:

> @@ -103,9 +104,9 @@
>  	
>  	internal class ParserContext: IParserContext
>  	{
> -		DefaultParserService parserService;
> -		CodeCompletionDatabase db;
> -		ParserDatabase pdb;
> +		protected DefaultParserService parserService;
> +		protected CodeCompletionDatabase db;
> +		protected ParserDatabase pdb;

Hmm, I don't see the need for this.

In CodeCompletionDatabase.cs:

> 
> +		protected void QueueAllFilesForParse ()
> +		{
> +			lock (rwlock)
> +			{
> +				foreach (FileEntry file in files.Values)
> +					file.LastParseTime = DateTime.MinValue;
> +			}
> +			UpdateDatabase ();
> +		}
> +		

It should not call UpdateDatabase since this method directly parses the
files, it does not queue them for parsing. You can use
CheckModifiedFiles instead.


> --- Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Commands/ProjectCommands.cs	(revision 67550)
> +++ Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Commands/ProjectCommands.cs	(working copy)
> @@ -61,7 +61,7 @@
>  	{
>  		Document doc;
>  		
> -		protected override void Run ()
> +		public void Run ()
>  		{
>  			if (IdeApp.ProjectOperations.CurrentOpenCombine != null) {

Why is this change needed?

The patch has some changes on the file ErrorListPad.cs which doesn't
exist, so I haven't been able to try it. But it looks good.

Thanks!
Lluis.