lluis at ximian.com
Mon Jul 10 06:33:42 EDT 2006
Thanks for the patch! A few comments:
* You need to unsubscribe the ParseInformationChanged event in the
Dispose method, or you'll keep references to all opened editors
* The idea of the 1 sec delay is to avoid updating the combo at
every key press, but you are only delaying the updates, not
avoiding them. That is, if you get a ParseInformationChanged
event, and a combo update is already scheduled, you should not
schedule a new update.
* Instead of using a dictionary to store name->IClass relations,
you can add a new data item in the list store of type Object,
and directly store the IClass or IMember reference there.
* We need the corresponding ChangeLog entries.
And a couple of "nice to have":
* It would be nice to add an option to the editor configuration
panel to enable/disable the class bar.
* It would be nice to always show in the method combo the method
on which the editor cursor is positioned.
El dg 09 de 07 del 2006 a les 22:28 +0100, en/na James Fitzsimons va
> Hi all,
> Attached is a patch I hope people will find useful. It adds a couple of
> combos to the top of the editor that provide quick access to classes and
> their methods/properties/members in the same manner as VS.NET allows.
> The combos are rebuilt dynamically as the parse information changes, so
> as you type in a new method signature it will appear in the method
> If the file doesn't provide any valid parse information e.g it is
> an .aspx file rather than a .cs file the combos disappear.
> This is my first real contribution to MonoDevelop so please go easy on
> me! I hope I have followed coding conventions properly. Also I didn't
> know what the etiquette around adding my name to the Authors list was so
> if it isn't appropriate please remove it.
> James Fitzsimons
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
More information about the Monodevelop-list