[MonoDevelop] [PATCH] NUnit 2.2.8.0 compliance

[Jacob Ilsø Christensen]

On 12/5/06, Lluis Sanchez <lluis at ximian.com> wrote:
> El dt 05 de 12 del 2006 a les 17:40 +0100, en/na Jacob Ilsø Christensen
> va escriure:
> > On 12/5/06, Lluis Sanchez <lluis at ximian.com> wrote:
> > > I tried running tests and it didn't work, I got an error. The problem
> > > may be that the external process that runs the tests may be loading the
> > > wrong dll (I have 2.2.0.0 in the gac).
> >
> > I tried running some tests too and it worked. I also have 2.2.0.0 in
> > the GAC. What error did you get?
>
> I get this error:
>
> System.NullReferenceException: Object reference not set to an instance
> of an object
>
> Server stack trace:
>   at
> MonoDevelop.NUnit.TestResultsPad.MonoDevelop.NUnit.ITestProgressMonitor.EndTest (MonoDevelop.NUnit.UnitTest test, MonoDevelop.NUnit.UnitTestResult result) [0x00000]
>   at <0x00000> <unknown method>
>   at (wrapper managed-to-native)
> System.Runtime.Remoting.RemotingServices:InternalExecute
> (System.Reflection.MethodBase,object,object[],object[]&)
>   at System.Runtime.Remoting.RemotingServices.InternalExecuteMessage
> (System.MarshalByRefObject target, IMethodCallMessage reqMsg) [0x00073]
> in /home/lluis/work/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs:125
>
> Exception rethrown at [0]:
>
>   at
> MonoDevelop.NUnit.TestResultsPad.MonoDevelop.NUnit.ITestProgressMonitor.EndTest (MonoDevelop.NUnit.UnitTest test, MonoDevelop.NUnit.UnitTestResult result) [0x00000]
>   at <0x00000> <unknown method>
>   at (wrapper managed-to-native)
> System.Runtime.Remoting.RemotingServices:InternalExecute
> (System.Reflection.MethodBase,object,object[],object[]&)
>   at System.Runtime.Remoting.RemotingServices.InternalExecuteMessage
> (System.MarshalByRefObject target, IMethodCallMessage reqMsg) [0x00073]
> in /home/lluis/work/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs:125

I can't reproduce it on my system, so it might be a bit hard to fix. I
found one place that looked suspect though. I have attached a patch
which fixes this issue.

/Jacob

>
>
> It works fine without the patch.
>
> >
> > /Jacob
> >
> > >
> > > El dl 04 de 12 del 2006 a les 20:34 +0100, en/na Jacob Ilsø Christensen
> > > va escriure:
> > > > On 12/4/06, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > > > > On 12/4/06, Charlie Poole <charlie at pooleconsulting.com> wrote:
> > > > > > Hi Lluis,
> > > > > >
> > > > > > > The problem is that with this patch the add-in won't compile
> > > > > > > with NUnit 2.2.0.0. The solution is to add the NUnit dlls
> > > > > > > into the nunit add-in, so we can avoid depending on the
> > > > > > > specific version installed in each system.
> > > > > >
> > > > > > I think adding a later version of the nunit dlls - the subset
> > > > > > that you require - to the monodevelop distribution is a great
> > > > > > first step.
> > > > >
> > > > > Yes. I am working on this atm. Just so no one else does it too. :-)
> > > >
> > > > Here goes. The attached patch makes the NUnit add-in use the nunit dll
> > > > from a local lib dir instead of that in the GAC.
> > > >
> > > > To try it out you need to place nunit.core.dll in Extras/NUnit/lib. I
> > > > used version 2.2.9 for .NET 2.0.
> > > >
> > > > It seems to work, but I cannot remember how well failed tests show up
> > > > in the test runner. Are line numbers usually included?
> > > >
> > > > Let me know if you find any problems.
> > > >
> > > > /Jacob
> > > >
> > > > >
> > > > > > In the longer run, I'd rather give you an assembly that
> > > > > > provides a façade to whatever version of NUnit the user
> > > > > > cares to use, and possibly allows selection at runtime.
> > > > > >
> > > > > > Charlie
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > >
> > >
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nunit2.patch
Type: text/x-patch
Size: 666 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20061205/44909f04/attachment.bin