[MonoDevelop] Win32 patch

John Luke john.luke at gmail.com
Thu Aug 31 23:06:47 EDT 2006


On Thu, 2006-08-31 at 17:37 -0500, Levi Bard wrote:
> Comments?
Is this for mono on windows or .net or both?

Also, there seems to be a bunch of whitespace changes which makes it
hard to review.

I didn't review the whole thing but here are some:
+ char splitc = SystemPackage.IsWin32 ? ';' : ':' ;

I think just use System.IO.Path.DirectorySeperatorChar for this


For all the path stuff like:
file = file.Substring (7);
if (file.StartsWith("/") && SystemPackage.IsWin32)
    file =file.Substring(1);

if (SystemPackage.IsWin32)
    datadir = datadir.Replace("\\","/");

it would probably be better if:
1) we just use '/' unconditionally on windows also (assuming that works
like someone told me it does)
2) we add helper methods (maybe in FileUtilityService?) to do that stuff
3) consistently use file:// Uris or regular paths and stop converting
to/from them all the time

More information about the Monodevelop-list mailing list