[MonoDevelop] SourceEditorDisplayBinding.patch

[James Fitzsimons]

Hi all,
Work commitments and a busy summer has kept me from finishing this but I
have a new version ready.

On Mon, 2006-07-10 at 12:33 +0200, Lluis Sanchez wrote:
> Thanks for the patch! A few comments:
> 
>       * You need to unsubscribe the ParseInformationChanged event in the
>         Dispose method, or you'll keep references to all opened editors
>         forever.
>       * The idea of the 1 sec delay is to avoid updating the combo at
>         every key press, but you are only delaying the updates, not
>         avoiding them. That is, if you get a ParseInformationChanged
>         event, and a combo update is already scheduled, you should not
>         schedule a new update.
>       * Instead of using a dictionary to store name->IClass relations,
>         you can add a new data item in the list store of type Object,
>         and directly store the IClass or IMember reference there.
>       * We need the corresponding ChangeLog entries.
I think I have addressed all of these issues now.

> And a couple of "nice to have":
> 
>       * It would be nice to add an option to the editor configuration
>         panel to enable/disable the class bar.
This one is done, not sure if it is the best place but you can turn the
class bar on and off on the behaviour tab of the text editor properties.

>       * It would be nice to always show in the method combo the method
>         on which the editor cursor is positioned.
I spent some time looking into this one. I thought it would be easy but 
unfortunately I am struggling to find a way to figure out what method the
cursor is currently in. As I probably won't have much time to work on
this in the immediate future I've added it to my TODO list and thought
I'd submit a patch without it. Better to have some features than none at
all right!

Cheers,
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SourceEditorDisplayBinding.patch
Type: text/x-patch
Size: 21866 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20060812/39388fee/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20060812/39388fee/attachment-0003.bin