[MonoDevelop] SourceCodeElement patch

[Lluis Sanchez]

On dl, 2005-05-23 at 18:42 +0200, Jacob Ilsø Christensen wrote:
> Hi.
> 
> I have attached a ISourceElement file as well as a patch which lets
> IClass and IMember implement this interface.
> 
> The interface has a FullyQualifiedName (for monodoc and tool tips), an
> IReturnType (for code completion purposes) and an IRegion (for jump to
> declaration).

I'm not sure we really need a ReturnType property at this level, since
it does not make sense for classes. We can always downcast to IMember to
get that value if we need to (we need to downcast anyways, since the
behavior of code completion won't be the same for classes and for
members). Other than that, the patch looks good.

> 
> There is one issue. An IClass is more or less an IReturnType, so maybe
> IClass should implement IReturnType as well and the IReturnType
> property would just return this?
> What do you think?

I think you are probably right, and IReturnType should be renamed to
IType or something like that. However, I also think that there is no
real need to do this change now, since it doesn't provide any practical
benefit.

> 
> Any comments on the patch apart from this? After this I will integrate
> stuff into the Resolver and TypeVisitor classes and finally the new
> information will be available to use for the above mentioned features.
> 
> /Jacob
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list