[MonoDevelop] ClassPad fix

[Jacob Ilsø Christensen]

Hi.

The attached patch changes the SourceEditorDisplayBinding to 1-based
and updates users accordingly. Looks ok?

/Jacob

On 6/22/05, Rafael Teixeira <monoman at gmail.com> wrote:
> I vote to make the BindingClass 1-based as it maps directly with what
> the user editing a source file is expecting. All classes using it
> should be corrected to deal with this 1-based design.
> 
> :)
> 
> On 6/22/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > So what is the general opinion?
> >
> > Right now the SourceEditorDisplayBinding class is 0 based. Some users
> > of the class use it as 0 based and some as 1 based. Should the users
> > be changed to use it as 0 based or should the class be changed to be 1
> > based (and the users updated accordingly).
> >
> > /Jacob
> >
> > On 6/19/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > > As a side note, the GotoLineNumber dialog does a -1 on the entered
> > > line number before calling JumpTo.
> > >
> > > /Jacob
> > >
> > > On 6/18/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > > > Hi.
> > > >
> > > > I looked at the SourceEditorDisplayBinding class. The first comment in
> > > > the JumpTo method is this:
> > > >
> > > > // NOTE: 0 based!
> > > >
> > > > So it seems someone already knew of this issue. Should we make it 1 based?
> > > >
> > > > /Jacob
> > > >
> > > > On 6/18/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > > > > Ok, it is the text view that is broken then. When you click in the
> > > > > Class view, a jump is made to e.g. line 2. This makes the text view
> > > > > jump to the third line and not the second. So I guess the c# parser is
> > > > > fine and the view is not.
> > > > >
> > > > > /Jacob
> > > > >
> > > > > On 6/18/05, Todd Berman <tberman at off.net> wrote:
> > > > > > On Fri, 2005-06-17 at 20:40 +0200, Jacob Ilsø Christensen wrote:
> > > > > > > Hi.
> > > > > > >
> > > > > > > I changed the C# Lexer instead. The attached patch makes the ClassPad
> > > > > > > work as it should. Does anyone know if this will impact other parts of
> > > > > > > MD?
> > > > > > >
> > > > > >
> > > > > > Yes, I am sure it will.
> > > > > >
> > > > > > There are lots of other places at assume it starts at 1.
> > > > > >
> > > > > > Speaking of that, why shouldn't it? I mean, the first line is 1. If
> > > > > > TextView thinks the first line is line 0, then that is whats broken.
> > > > > >
> > > > > > --Todd
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> >
> 
> 
> --
> Rafael "Monoman" Teixeira
> ---------------------------------------
> I'm trying to become a "Rosh Gadol" before my own eyes.
> See http://www.joelonsoftware.com/items/2004/12/06.html for enlightment.
> It hurts!
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: one-based-source-editor.patch
Type: text/x-patch
Size: 3241 bytes
Desc: not available
Url : http://galactus.ximian.com/pipermail/monodevelop-list/attachments/20050627/8ffab910/one-based-source-editor-0001.bin