[MonoDevelop] ClassPad fix

Jacob Ilsø Christensen jacobilsoe at gmail.com
Sun Jun 19 05:11:28 EDT 2005


As a side note, the GotoLineNumber dialog does a -1 on the entered
line number before calling JumpTo.

/Jacob

On 6/18/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> Hi.
> 
> I looked at the SourceEditorDisplayBinding class. The first comment in
> the JumpTo method is this:
> 
> // NOTE: 0 based!
> 
> So it seems someone already knew of this issue. Should we make it 1 based?
> 
> /Jacob
> 
> On 6/18/05, Jacob Ilsø Christensen <jacobilsoe at gmail.com> wrote:
> > Ok, it is the text view that is broken then. When you click in the
> > Class view, a jump is made to e.g. line 2. This makes the text view
> > jump to the third line and not the second. So I guess the c# parser is
> > fine and the view is not.
> >
> > /Jacob
> >
> > On 6/18/05, Todd Berman <tberman at off.net> wrote:
> > > On Fri, 2005-06-17 at 20:40 +0200, Jacob Ilsø Christensen wrote:
> > > > Hi.
> > > >
> > > > I changed the C# Lexer instead. The attached patch makes the ClassPad
> > > > work as it should. Does anyone know if this will impact other parts of
> > > > MD?
> > > >
> > >
> > > Yes, I am sure it will.
> > >
> > > There are lots of other places at assume it starts at 1.
> > >
> > > Speaking of that, why shouldn't it? I mean, the first line is 1. If
> > > TextView thinks the first line is line 0, then that is whats broken.
> > >
> > > --Todd
> > >
> > >
> >
>


More information about the Monodevelop-list mailing list