[MonoDevelop] Bugzilla Bug Bugzilla bug 57782

[Lluis Sanchez]

El dj 02 de 06 del 2005 a les 22:03 +0200, en/na Jacob Ilsø Christensen
va escriure:
> Hi.
> 
> On 6/2/05, Lluis Sanchez <lluis at ximian.com> wrote:
> > El dj 02 de 06 del 2005 a les 21:24 +0200, en/na Jacob Ilsø Christensen
> > va escriure:
> > > Does this look better?
> > 
> > The patch looks fine. Just two comments.
> > 1) I think you are missing a return after:
> > this.ParentCombine.RemoveReferencesToProject(projectToRemove);
> 
> Hmm, maybe I don't understand what ParentCombines are, but do I not
> need to iterate each parents projects or is it only the topmost parent
> that needs to be iterated?

GetAllProjects recursively gets all projects below the combine, so
running the remove loop for the root combine is enough to remove all
references (that is, there is no need to do anything else after calling
this.ParentCombine.RemoveReferencesToProject).

> 
> > 
> > 2) Runtime.ProjectService.GetProject() will only look for projects in
> > the combine opened in the ide. This will work for what we need now, but
> > it is not fully correct, since an addin may want to manage its own tree
> > of projects. I know there are other classes in Internal/Project that
> > depend on Runtime.ProjectService, we need to remove all those
> > dependencies soon or later. For what you want to do, comparing the name
> > of the project is enough, since the project name is unique in the
> > project tree.
> > 
> > Feel free to commit after those minor corrections.
> > Thanks!
> > 
> > Lluis.
> > 
> > >
> > > /Jacob
> > >
> > > On 6/2/05, Lluis Sanchez <lluis at ximian.com> wrote:
> > > > Hi,
> > > >
> > > > Thanks for the patch. The logic that keeps the project reference
> > > > consistency should be implemented in the Combine class, so it always
> > > > works even when a project is not deleted from the Project tree, but from
> > > > some other GUI that an addin can provide. I also don't see the need of
> > > > asking for confirmation to delete the references, since references are
> > > > useless if the referenced project doesn't exist.
> > > >
> > > > The algorithm for removing references should also take into account that
> > > > the project can be referenced from other combines, not only from the one
> > > > from which it is removed. I just added a property in CombineEntry that
> > > > will return the parent Combine, so you can go up in the project
> > > > hierarchy.
> > > >
> > > > Lluis.
> > > >
> > > > El dj 02 de 06 del 2005 a les 19:45 +0200, en/na Jacob Ilsø Christensen
> > > > va escriure:
> > > > > Hi.
> > > > >
> > > > > The attached patch fixes bugzilla bug 57782. Does it look ok?
> > > > >
> > > > > /Jacob
> > > > > _______________________________________________
> > > > > Monodevelop-list mailing list
> > > > > Monodevelop-list at lists.ximian.com
> > > > > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> > > >
> > > > _______________________________________________
> > > > Monodevelop-list mailing list
> > > > Monodevelop-list at lists.ximian.com
> > > > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> > > >
> > > _______________________________________________
> > > Monodevelop-list mailing list
> > > Monodevelop-list at lists.ximian.com
> > > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> > 
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> >