[MonoDevelop] monodoc patch

[Jacob Ilsø Christensen]

On 6/1/05, Lluis Sanchez <lluis at ximian.com> wrote:
> Hi,
> 
> Some comments:
> 
> - public IReturnType SearchMember(IReturnType type, string memberName)
> + public ISourceCodeElement SearchMember(ISourceCodeElement type, string
> memberName)
> 
> Why does the type parameter need to be a ISourceCodeElement? It doesn't
> make sense to me. Only types can have members.

Yeah, you're probably right will have a look at that one.

> 
> Why is the SourceCodeElement class needed? Looks like a very ambiguous
> class to me. I see it being used in SearchMethodParameter(). Maybe
> IParameter should implement ISourceCodeElement?
> 

Will have a look.

> I hope the refactoring will include removing the MonodocResolver method.
> We really don't need it if the Resolve can return an ISourceCodeElement
> inside the ResolveResult object.

Yes, the refactoring will certainly move all the monodoc code to the
monodoc service you mentioned earlier. The resolver should know
nothing about monodoc.

> Other than that, I think the patch is going to the right direction.

Sounds good. I will look at the issues above and send out a new patch.

/Jacob

> 
> Lluis.
> 
> El dt 31 de 05 del 2005 a les 21:29 +0200, en/na Jacob Ilsø Christensen
> va escriure:
> > Hi.
> >
> > I finally made the patch which generalizes the resolver and
> > typevisitor to allow for complete monodoc support as well as goto
> > declaration.
> >
> > It still needs some refactoring and cleaning up, but the basic
> > functionality should more or less be in place. I have made monodoc
> > support for properties and fields. I have not made goto declaration
> > yet, but that one is easy now and I will do that next.
> >
> > Will someone look through the patch as I would like to commit this and
> > then refactor afterwards so the patch won't be too big (I know the
> > ChangeLogs are missing but I will add them as appropriate).
> >
> > After this I will make goto declaration. Then:
> >
> > - fix some bugs with local variables
> > - support for methods
> >
> > Then I would like to introduce some on-the-fly syntax checking. Is
> > that something we want for MD?
> >
> > Then more navigation and then possibly refactoring support.
> >
> > /Jacob
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list
>